-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Specify k8s node version for systemtest nodepool #6642
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## develop #6642 +/- ##
=========================================
- Coverage 80.1% 80.1% -0.1%
=========================================
Files 358 358
Lines 47999 47999
=========================================
- Hits 38484 38483 -1
- Misses 7351 7357 +6
+ Partials 2164 2159 -5 ☔ View full report in Codecov by Sentry. |
fasmat
approved these changes
Jan 19, 2025
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Jan 20, 2025
## Motivation Ensure that the Kubernetes node pool for systest uses a specific, predefined node version rather than the latest available version for the cluster.
Pull request successfully merged into develop. Build succeeded: |
kacpersaw
added a commit
that referenced
this pull request
Jan 21, 2025
* build(deps): Bump google.golang.org/protobuf from 1.36.2 to 1.36.3 (#6620) * remove @acud from CODEOWNERS (#6622) * sync2: enable server mode by default and adjust settings (#6614) ## Motivation We need to have syncv2 enabled for everyone for further testing of active syncv2. Current default settings differ from what was verified on mainnet so far, and need to be made more conservative to be on the safe side. * build(deps): Bump github.com/prometheus/common from 0.61.0 to 0.62.0 (#6632) * build(deps): Bump k8s.io/client-go from 0.32.0 to 0.32.1 (#6634) * Build mac-arm64 and push to docker hub (#6617) ## Motivation Build and push mac-arm64 image * Execute delete-pool always if nondocchanges == true (#6626) ## Motivation The current systest workflow fails when merging a change that doesn't execute system tests, i.e. only documentation was changed. This should fix the issue. * Specify k8s node version for systemtest nodepool (#6642) ## Motivation Ensure that the Kubernetes node pool for systest uses a specific, predefined node version rather than the latest available version for the cluster. * Introduce v2beta1 and migrate v2alpha1 POST API calls to GET (#6636) * sync2: adjust settings again (#6629) ## Motivation Need proper defaults for mainnet. There were systest flakes with `syncv2` server mode enabled possibly due to increased resource usage. * Merge --------- Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Bartosz Różański <[email protected]> Co-authored-by: Ivan Shvedunov <[email protected]> Co-authored-by: andres-spacemesh <[email protected]> Co-authored-by: Matthias Fasching <[email protected]> Co-authored-by: andres-spacemesh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Ensure that the Kubernetes node pool for systest uses a specific, predefined node version rather than the latest available version for the cluster.
Description
Ensures that the node pool for systests is created with a specific Kubernetes version, as defined in the secrets, instead of automatically using the latest available version for the cluster. This provides better control and stability for testing environments by avoiding potential issues with newer, untested Kubernetes versions.