Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Specify k8s node version for systemtest nodepool #6642

Closed
wants to merge 1 commit into from

Conversation

andres-spacemesh
Copy link
Contributor

Motivation

Ensure that the Kubernetes node pool for systest uses a specific, predefined node version rather than the latest available version for the cluster.

Description

Ensures that the node pool for systests is created with a specific Kubernetes version, as defined in the secrets, instead of automatically using the latest available version for the cluster. This provides better control and stability for testing environments by avoiding potential issues with newer, untested Kubernetes versions.

Copy link

codecov bot commented Jan 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.1%. Comparing base (cfea985) to head (667daec).
Report is 1 commits behind head on develop.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop   #6642     +/-   ##
=========================================
- Coverage     80.1%   80.1%   -0.1%     
=========================================
  Files          358     358             
  Lines        47999   47999             
=========================================
- Hits         38484   38483      -1     
- Misses        7351    7357      +6     
+ Partials      2164    2159      -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fasmat
Copy link
Member

fasmat commented Jan 20, 2025

bors merge

spacemesh-bors bot pushed a commit that referenced this pull request Jan 20, 2025
## Motivation

Ensure that the Kubernetes node pool for systest uses a specific, predefined node version rather than the latest available version for the cluster.
@spacemesh-bors
Copy link

Pull request successfully merged into develop.

Build succeeded:

@spacemesh-bors spacemesh-bors bot changed the title Specify k8s node version for systemtest nodepool [Merged by Bors] - Specify k8s node version for systemtest nodepool Jan 20, 2025
@spacemesh-bors spacemesh-bors bot closed this Jan 20, 2025
@spacemesh-bors spacemesh-bors bot deleted the set-systest-k8s-node-version branch January 20, 2025 10:08
kacpersaw added a commit that referenced this pull request Jan 21, 2025
* build(deps): Bump google.golang.org/protobuf from 1.36.2 to 1.36.3 (#6620)

* remove @acud from CODEOWNERS (#6622)

* sync2: enable server mode by default and adjust settings (#6614)

## Motivation

We need to have syncv2 enabled for everyone for further testing of active syncv2.
Current default settings differ from what was verified on mainnet so far, and need to be made more conservative to be on the safe side.

* build(deps): Bump github.com/prometheus/common from 0.61.0 to 0.62.0 (#6632)

* build(deps): Bump k8s.io/client-go from 0.32.0 to 0.32.1 (#6634)

* Build mac-arm64 and push to docker hub (#6617)

## Motivation
Build and push mac-arm64 image

* Execute delete-pool always if nondocchanges == true (#6626)

## Motivation

The current systest workflow fails when merging a change that doesn't execute system tests, i.e. only documentation was changed. This should fix the issue.

* Specify k8s node version for systemtest nodepool (#6642)

## Motivation

Ensure that the Kubernetes node pool for systest uses a specific, predefined node version rather than the latest available version for the cluster.

* Introduce v2beta1 and migrate v2alpha1 POST API calls to GET (#6636)

* sync2: adjust settings again (#6629)

## Motivation

Need proper defaults for mainnet.
There were systest flakes with `syncv2` server mode enabled possibly due to increased resource usage.

* Merge

---------

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Bartosz Różański <[email protected]>
Co-authored-by: Ivan Shvedunov <[email protected]>
Co-authored-by: andres-spacemesh <[email protected]>
Co-authored-by: Matthias Fasching <[email protected]>
Co-authored-by: andres-spacemesh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants