[Merged by Bors] - hare3: simpify and deflake synchronization in cluster tests #5033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshulyak
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #5033 +/- ##
=========================================
- Coverage 77.0% 77.0% -0.1%
=========================================
Files 257 257
Lines 30242 30236 -6
=========================================
- Hits 23314 23308 -6
- Misses 5401 5402 +1
+ Partials 1527 1526 -1
|
dshulyak
force-pushed
the
hare3/simplify-synchronization
branch
from
a0793c5 to
1476d8f
Compare
dshulyak
changed the title
dshulyak
requested review from
countvonzero,
fasmat and
poszu
as code owners
fasmat
approved these changes
Sep 19, 2023
|
i didn't observe any failures during the day. will merge and see if i missed something |
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Sep 19, 2023
closes: #4990 there are 2 important events that needs to be in sync: 1. walltime.Sub(t.clock.Now()) needs to be called after call to Advance in tests 2. Advance needs to be called after all eligible messages were processed 1st synchronization point is realized by waiting on computing vrf. code calls Advance, and waits for read on eligibility channel. note that event is submitted even if eligibility is nil. 2nd synchronization point is realized by waiting until message is processed by all nodes in the cluster. code calls Publish, when Publish exists message was delivered and processed by every node. so when read on sent channel is received we know that all messages were processed.
|
Build failed: |
4 tasks
|
known flaky test #4171 bors merge |
bors bot
pushed a commit
that referenced
this pull request
Sep 19, 2023
closes: #4990 there are 2 important events that needs to be in sync: 1. walltime.Sub(t.clock.Now()) needs to be called after call to Advance in tests 2. Advance needs to be called after all eligible messages were processed 1st synchronization point is realized by waiting on computing vrf. code calls Advance, and waits for read on eligibility channel. note that event is submitted even if eligibility is nil. 2nd synchronization point is realized by waiting until message is processed by all nodes in the cluster. code calls Publish, when Publish exists message was delivered and processed by every node. so when read on sent channel is received we know that all messages were processed.
|
Build failed: |
|
known flaky test bors merge |
bors bot
pushed a commit
that referenced
this pull request
Sep 19, 2023
closes: #4990 there are 2 important events that needs to be in sync: 1. walltime.Sub(t.clock.Now()) needs to be called after call to Advance in tests 2. Advance needs to be called after all eligible messages were processed 1st synchronization point is realized by waiting on computing vrf. code calls Advance, and waits for read on eligibility channel. note that event is submitted even if eligibility is nil. 2nd synchronization point is realized by waiting until message is processed by all nodes in the cluster. code calls Publish, when Publish exists message was delivered and processed by every node. so when read on sent channel is received we know that all messages were processed.
|
Pull request successfully merged into develop. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #4990
there are 2 important events that needs to be in sync:
1st synchronization point is realized by waiting on computing vrf. code calls Advance, and waits for read on eligibility channel. note that event is submitted even if eligibility is nil.
2nd synchronization point is realized by waiting until message is processed by all nodes in the cluster. code calls Publish, when Publish exists message was delivered and processed by every node. so when read on sent channel is received we know that all messages were processed.