Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky TestAccountMeshDataStream_comprehensive test #4171

Closed
poszu opened this issue Mar 20, 2023 · 0 comments
Closed

Flaky TestAccountMeshDataStream_comprehensive test #4171

poszu opened this issue Mar 20, 2023 · 0 comments
Assignees
@fasmat
Labels
bug

Comments

@poszu
Copy link
Contributor

poszu commented Mar 20, 2023

Description

Test TestAccountMeshDataStream_comprehensive is flaky:

--- FAIL: TestAccountMeshDataStream_comprehensive (1.00s)
    grpcserver_test.go:2138: 
        	Error Trace:	/home/runner/work/go-spacemesh/go-spacemesh/api/grpcserver/grpcserver_test.go:2138
        	Error:      	Not equal: 
        	            	expected: 0x2
        	            	actual  : 0x4
        	Test:       	TestAccountMeshDataStream_comprehensive

Steps to reproduce

The problem was observed in regular CI run.
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Dev team kanban Mar 20, 2023
@dshulyak dshulyak removed the flakiness label Sep 3, 2023
@poszu poszu mentioned this issue Sep 14, 2023
Closed
@fasmat fasmat mentioned this issue Sep 19, 2023
Closed
@fasmat fasmat self-assigned this Sep 25, 2023
@fasmat fasmat moved this from 📋 Backlog to 🏗 Doing in Dev team kanban Sep 25, 2023
@fasmat fasmat mentioned this issue Sep 25, 2023
Closed
4 tasks
bors bot pushed a commit that referenced this issue Sep 25, 2023
@fasmat
Fix flaky TestAccountMeshDataStream_comprehensive (#5075)
16b5ad9 
## Motivation
Closes #4171 

Occasionally the test will fail with an incorrect assertion of an error. The stream receive can fail either because the deadline was exceeded or due to bad timing for another (random) reason. Since it doesn't matter which return code is received, just that the stream ended I changed the assertion to also allow `code.Unkown`.

## Changes
- change assertion to allow `codes.DeadlineExceeded` and `codes.Unkown` instead of just the former.
- Additionally get rid of the global GRPC config. This will allow to run GRPC service tests in parallel (which will be used by #5061)

## Test Plan
<!-- Please specify how these changes were tested
(e.g. unit tests, manual testing, etc.) -->

## TODO
<!-- This section should be removed when all items are complete -->
- [x] Explain motivation or link existing issue(s)
- [x] Test changes and document test plan
- [x] Update documentation as needed
- [ ] Update [changelog](../CHANGELOG.md) as needed
@bors bors bot closed this as completed in 0b084e9 Sep 25, 2023
@dshulyak dshulyak moved this from 🏗 Doing to ✅ Done in Dev team kanban Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fasmat fasmat

Labels
bug
Projects
Dev team kanban
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Merged by Bors] - Fix flaky TestAccountMeshDataStream_comprehensive spacemeshos/go-spacemesh
3 participants
@dshulyak @poszu @fasmat