Patch body-parser to use json-bigint, like gateway #922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh whoops that commit isn't meant to be in here |
|
Turns out this patch may be unnecessary at some point: expressjs/body-parser#282 |
MaddyUnderStars
added a commit
that referenced
this pull request
Mar 1, 2023
Patch body-parser to use json-bigint, like gateway
|
@MaddyUnderStars yeah, as author of that PR you mentioned, I wouldn't get your hopes up. I come back to that PR every couple years, get it up to date, and try to get it merged but it looks like it's probably just not happening |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a patch file for body-parser, which replaces usage of
JSON.parsewithjson-bigint, as was done with the gateway and it's usage ofJSON.parsefor incoming messages.Addresses #696, and would fix mobile client replies, and dsharpplus support as notable examples.
Making this a PR so it's more visible for testers. I'm not very pleased with having to patch body-parser. I also haven't tested this yet with dsharpplus or the mobile client themselves, just through curl mimicking the requests.