IDs don't seem to be parsed properly when received as numbers?

[minhducsun2002]

I'm having issues replying to messages. My message object contains something like this on the sending side :

"message_reference": {
	"message_id":954979821636042816,
	"channel_id":954027702603522075,
	"guild_id":954027701865324570,
	"fail_if_not_exists":false
}

However, the server gets it (I inserted a console.log @ https://github.com/fosscord/fosscord-server/blob/master/api/src/util/handlers/Message.ts#L85) as

{
  message_id: '954979821636042800',
  channel_id: '954027702603522000',
  guild_id: '954027701865324500',
  fail_if_not_exists: false
}

The 00 suffixes on the received data signalled to me that there seems to be truncation happening due to the numbers stepping outside of JavaScript's safe limit on integers (Number.MAX_SAFE_INTEGER). Discord works fine with this however.

[MaddyUnderStars]

This bug is due to how body-parser uses JSON.parse, which uses Number types instead of BigInt or string for large numbers. A similar fix was already done with the gateway ( swapping our usage of JSON.parse with the json-bitint npm package ), but for body-parser we'd have to patch the library. I've done a bit of local testing and it seems fine, but patching such an important package is a bit awkward. Maybe conditionally use json-bitint?

[MaddyUnderStars]

Addressed in #309 and 22346c4