Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(json): Call to a member function getValue() on null in JsonContex… #26

Merged
merged 2 commits into from
Jan 12, 2024
Merged

fix(json): Call to a member function getValue() on null in JsonContex… #26

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d49b7b
fix(json): Call to a member function getValue() on null in JsonContex…
walva Dec 21, 2023
489aa85
fix NoSuchDriver exception hanlding
Jean-Beru Jan 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions src/HttpCall/HttpCallListener.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,6 @@ public function afterStep(AfterStepTested $event)
return true;
}

// Session can be stopped. Ex: using SystemContext
if (!$this->mink->getSession()->isStarted()) {
return;
}

// For now to avoid modification on MinkContext
// We add fallback on Mink
try {
Expand All @@ -63,6 +58,8 @@ public function afterStep(AfterStepTested $event)
// Mink has no response
} catch (\Behat\Mink\Exception\DriverException $e) {
// No Mink
} catch (\WebDriver\Exception\NoSuchDriver $e) {
// A session is either terminated or not started
}
}
}