-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(json): Call to a member function getValue() on null in JsonContex… #26
Conversation
Every tests work locally except I assume it is due to PHP 8.2
|
I also have the same issue with all rest requests: |
Thanks for your PR @walva. The CI still fail due to an catch(\WebDriver\Exception $e) {
// No WebDriver
} WDYT ? |
Hello @Jean-Beru, I trust you if you tell me it's needed. I would say we could also let the exception propagate. Furthermore, I am unable to express any strong opinion because of my level of knowledge of this package. Regarding the error, do you know how I can reproduce locally? I see in the CI the error is with PHP 8.1 & |
I finally reproduced this fail using act, its full Ubuntu image (18Gb 😱) and some fixes! The error is due to the I think that we can add the following catch to solve the issue: } catch (\WebDriver\Exception\NoSuchDriver $e) {
// A session is either terminated or not started
} @walva Can you update your PR, test it in your CI and push please ? |
@Jean-Beru I'm working on it. I've installed act. Thanks for the help! Presently, I cannot run any behat job on my machine. What machine do you have ? (I have a Macbook M series) |
Here is the stack trace I have, while commenting .github/workflows/ci.yml:126 to only enable the profile symfony2 which is failing. I will try at home with a windows machine (WSL)
|
I'm working on Ubuntu.
If you want to run this action through act, you have to run Selenium, the PHP Server and Behat in the same job. It don't really know why. I tested the "try... catch" fix using act to go fast but can you test it directly in your PR? GitHub action will do the job. |
@walva It found how to add a commit to your PR. I applied the fix and it works! Thanks a lot for your help ❤️ |
@Jean-Beru thanks for your time and patience. I learned a lot and hope to help more in the future. |
fix(json): Call to a member function getValue() on null in JsonContext:getJson
See here : 8215019#r109969509
Ping @Jean-Beru @develth @NicoHaase