refactor: Make SourceHub dep internal-only #2963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewSisley
added
refactor
AndrewSisley
force-pushed
the
2962-rm-source-hub-dep
branch
2 times, most recently
from
5bbe206 to
67654e1
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2963 +/- ##
===========================================
- Coverage 79.28% 79.25% -0.03%
===========================================
Files 326 326
Lines 24768 24768
===========================================
- Hits 19635 19628 -7
- Misses 3715 3719 +4
- Partials 1418 1421 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 13 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
shahzadlone
approved these changes
Aug 26, 2024
There was a problem hiding this comment.
Change LGTM even if doesn't fix vul checker. I wish a silencing feature was there golang/go#61211
AndrewSisley
force-pushed
the
2962-rm-source-hub-dep
branch
from
67654e1 to
5e87f31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #2962
Description
I was mostly curious if this will make the vuln checker go green (it doesn't, it just reports it from our internal acp package now), but it is a good change anyway IMO to avoid embedded Go client users from having to directly import the dependency.