Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SourceHub sdk dep from test utils #2962

Closed
AndrewSisley opened this issue Aug 26, 2024 · 0 comments · Fixed by #2963
Closed

Remove SourceHub sdk dep from test utils #2962

AndrewSisley opened this issue Aug 26, 2024 · 0 comments · Fixed by #2963
Assignees
@AndrewSisley
Labels
area/testing Related to any test or testing suite ci/build This is issue is about the build or CI system, and the administration of it.
Milestone
DefraDB v0.14

Comments

@AndrewSisley
Copy link
Contributor

Mostly so the vuln checker goes green. Is quick to do, but the dep will probably come back medium term via a future sourcehub testing lib.
@AndrewSisley AndrewSisley added area/testing Related to any test or testing suite ci/build This is issue is about the build or CI system, and the administration of it. labels Aug 26, 2024
@AndrewSisley AndrewSisley added this to the DefraDB v0.14 milestone Aug 26, 2024
@AndrewSisley AndrewSisley self-assigned this Aug 26, 2024
@sourcenetwork sourcenetwork deleted a comment Aug 26, 2024
@AndrewSisley AndrewSisley mentioned this issue Aug 26, 2024
Merged
AndrewSisley added a commit that referenced this issue Aug 26, 2024
@AndrewSisley
refactor: Make SourceHub dep internal-only (#2963)
d5b034f 
## Relevant issue(s)

Resolves #2962

## Description

I was mostly curious if this will make the vuln checker go green (it
doesn't, it just reports it from our internal acp package now), but it
is a good change anyway IMO to avoid embedded Go client users from
having to directly import the dependency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndrewSisley AndrewSisley

Labels
area/testing Related to any test or testing suite ci/build This is issue is about the build or CI system, and the administration of it.
Projects
None yet
Milestone
DefraDB v0.14
Development

Successfully merging a pull request may close this issue.

refactor: Make SourceHub dep internal-only AndrewSisley/defradb
1 participant
@AndrewSisley