Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates and cleanup #147

Closed
wants to merge 12 commits into from
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -133,3 +133,5 @@ typings/
# End of https://www.gitignore.io/api/node,hugo,intellij

content/tutorials/kit-assembly.files

resources/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

??

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whilst Hugo advocate it, I think committing the CSS build cache is a god-awful idea! I could update the .gitignore from gitignore.io, but adding it to the bottom felt easier

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah it's the css cache! I didn't know that it was in the resources folder (I don't currently use this yet).

I agree with your decision

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also would not have known what this was. Please could we have a comment about what this is?

2 changes: 2 additions & 0 deletions config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,3 +39,5 @@ outputs:
- json

buildFuture: true

assetDir: static/
3 changes: 2 additions & 1 deletion layouts/partials/custom-header.html
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
<link href="/css/style.css" rel="stylesheet">
{{ $style := resources.Get "css/style.css" | resources.Minify | resources.Fingerprint }}
<link rel="stylesheet" href="{{ $style.Permalink }}" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using Permalink here interacts badly with netlify PR deploys as it's always a fully absolute path.

I think we want RelPermalink instead?