Updates and cleanup #147
Updates and cleanup #147
Conversation
| @@ -133,3 +133,5 @@ typings/ | |||
| # End of https://www.gitignore.io/api/node,hugo,intellij | |||
|
|
|||
| content/tutorials/kit-assembly.files | |||
|
|
|||
| resources/ | |||
There was a problem hiding this comment.
Whilst Hugo advocate it, I think committing the CSS build cache is a god-awful idea! I could update the .gitignore from gitignore.io, but adding it to the bottom felt easier
There was a problem hiding this comment.
Ah it's the css cache! I didn't know that it was in the resources folder (I don't currently use this yet).
I agree with your decision
There was a problem hiding this comment.
I also would not have known what this was. Please could we have a comment about what this is?
| @@ -0,0 +1,3 @@ | |||
| {{ $resource_name := .Get 0 }} | |||
|
|
|||
| {{ (.Page.Resources.GetMatch $resource_name).RelPermalink }} | |||
There was a problem hiding this comment.
Shiny, does this mean that we get build-time validation of these links?
There was a problem hiding this comment.
It does, though the error message is nasty:
INFO 2018/08/04 09:43:08 Using config file: /home/peter/sb/docs/config.yml
Building sites … INFO 2018/08/04 09:43:08 syncing static files to /home/peter/sb/docs/public/
INFO 2018/08/04 09:43:08 found taxonomies: map[string]string{}
panic: reflect: Method on nil interface value [recovered]
panic: reflect: Method on nil interface value
goroutine 148 [running]:
text/template.errRecover(0xc420f0d7f0)
/usr/local/go/src/text/template/exec.go:143 +0x1ba
panic(0xd761a0, 0x1072ec0)
/usr/local/go/src/runtime/panic.go:502 +0x229
reflect.Value.Method(0xe031c0, 0xc4205dff68, 0x94, 0x5, 0xc, 0x0, 0x0)
/usr/local/go/src/reflect/value.go:1151 +0x14f
reflect.Value.MethodByName(0xe031c0, 0xc4205dff68, 0x94, 0xc4206914ed, 0xc, 0x94, 0x1, 0x10841c0)
/usr/local/go/src/reflect/value.go:1186 +0x11b
<trimmed>
There was a problem hiding this comment.
This is probably preferable to no error message, but I'm adding it here for reference.
layouts/partials/custom-header.html
Outdated
| @@ -1 +1,2 @@ | |||
| <link href="/css/style.css" rel="stylesheet"> | |||
| {{ $style := resources.Get "css/style.css" | resources.Minify | resources.Fingerprint }} | |||
| <link rel="stylesheet" href="{{ $style.Permalink }}" /> | |||
There was a problem hiding this comment.
Using Permalink here interacts badly with netlify PR deploys as it's always a fully absolute path.
I think we want RelPermalink instead?
content/api/vision/_index.md
Outdated
| @@ -25,7 +25,5 @@ A marker's position can be represented using both the [Cartesian](coordinates/#c | |||
| {{% /notice %}} | |||
|
|
|||
| ## Marker PDFs | |||
| You can download PDF files of all markers: | |||
There was a problem hiding this comment.
Please can you cherry-pick 0f5f0a4 (removing the marker links) to the proper branch?
tpoomlmly
force-pushed
the
updates-and-cleanup
branch
from
75656bd to
a94307b
Compare
Fixes #108
Replaces #109
Contains:
0.45.1static/docs, and move to page assets