Fix source locations with --no-preprocessor and add a virtual file system layer to the parser
#2377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default virtual file system used by the parser is the real file system. And it's possible to initialize the parser driver with a different virtual file system. The Overlay file system is a stack of virtual file systems.
Source location were off by one line. The source location on the first line had an uninitialized column number. Error messages would point to the wrong column when the location is after consecutive non-leading whitespaces.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2377 +/- ##
==========================================
+ Coverage 77.52% 77.64% +0.11%
==========================================
Files 467 470 +3
Lines 30778 30966 +188
==========================================
+ Hits 23862 24043 +181
- Misses 6916 6923 +7
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes source locations with
--no-preprocessorand introduces a light virtual file system layer to the parser.By default the parser sees the real file system (through
RealFileSystem). But it is also possible to present any other object that implements the newFileSysteminterface. For intance theOverlayFileSystemcombines multiple stacked virtual file-system objects (à-la Docker).Adds a test that demonstrate the use of vfs with the
libsouffle.