Read preprocessed code into buffer before parsing #2387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamjseitz
force-pushed
the
preprocessor-output-as-buffer
branch
from
2207569
to
3e70718
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2387 +/- ##
==========================================
+ Coverage 77.56% 77.63% +0.07%
==========================================
Files 467 472 +5
Lines 30785 31042 +257
==========================================
+ Hits 23877 24100 +223
- Misses 6908 6942 +34
|
quentin
reviewed
Jan 13, 2023
adamjseitz
force-pushed
the
preprocessor-output-as-buffer
branch
from
3e70718
to
82e63ab
Compare
This change resolves a race condition that existed where the parser may close the preprocessor's output pipe, causing it to terminate. Souffle would then see the process terminated unsuccessfully, and and throw an exception instead of printing information about the parsing error.
adamjseitz
force-pushed
the
preprocessor-output-as-buffer
branch
from
82e63ab
to
b69ab2e
Compare
quentin
approved these changes
Feb 8, 2023
|
Thanks for the contribution ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change resolves a race condition that existed where the parser may close the preprocessor's output pipe, causing it to terminate. Souffle would then see the process terminated unsuccessfully, and and throw an exception instead of printing information about the parsing error.
Closes #2386