Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable sqlite3 URI filename capabilty #2199

Merged
merged 2 commits into from
Mar 5, 2022

Conversation

quentin
Copy link
Member

@quentin quentin commented Mar 4, 2022

Hello,
Test semantic/store3 recently modified by #2177 was failing with my Linux distribution (Fedora).

The sqlite3 URI filename capability is not always enabled by default, depending on the build options of sqlite3. This change enables the capability before opening a database.

Also fix minor error message typo.

@codecov
Copy link

codecov bot commented Mar 4, 2022

Codecov Report

Merging #2199 (6c731e5) into master (964c178) will increase coverage by 0.03%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2199      +/-   ##
==========================================
+ Coverage   75.55%   75.58%   +0.03%     
==========================================
  Files         452      452              
  Lines       27264    27266       +2     
==========================================
+ Hits        20599    20609      +10     
+ Misses       6665     6657       -8     
Impacted Files Coverage Δ
src/include/souffle/io/WriteStreamSQLite.h 69.71% <50.00%> (+0.17%) ⬆️
src/include/souffle/io/ReadStreamSQLite.h 76.34% <100.00%> (+0.25%) ⬆️
src/include/souffle/datastructure/BTree.h 97.47% <0.00%> (+0.42%) ⬆️
src/include/souffle/utility/ParallelUtil.h 84.49% <0.00%> (+0.77%) ⬆️
src/include/souffle/datastructure/UnionFind.h 97.80% <0.00%> (+2.19%) ⬆️
src/include/souffle/datastructure/LambdaBTree.h 75.57% <0.00%> (+2.29%) ⬆️

Copy link
Member

@b-scholz b-scholz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@b-scholz b-scholz merged commit f24ac12 into souffle-lang:master Mar 5, 2022
@quentin quentin deleted the fixsqliteuri branch March 15, 2022 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants