Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow URI Filenames for SQLite Input and Output #2177

Merged
merged 1 commit into from
Feb 10, 2022

Conversation

cwarden
Copy link
Contributor

@cwarden cwarden commented Jan 19, 2022

When a file: or :memory: filename is used for a sqlite input or output
directive, pass directly to sqlite3_open() as-is rather than prepending
the fact directory to the filename.

When a file: or :memory: filename is used for a sqlite input or output
directive, pass directly to sqlite3_open() as-is rather than prepending
the fact directory to the filename.
@codecov
Copy link

codecov bot commented Jan 19, 2022

Codecov Report

Merging #2177 (d11266f) into master (5bef4c1) will increase coverage by 0.20%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2177      +/-   ##
==========================================
+ Coverage   75.34%   75.54%   +0.20%     
==========================================
  Files         450      452       +2     
  Lines       27283    27253      -30     
==========================================
+ Hits        20556    20589      +33     
+ Misses       6727     6664      -63     
Impacted Files Coverage Δ
src/include/souffle/io/ReadStreamSQLite.h 76.08% <50.00%> (-0.58%) ⬇️
src/include/souffle/io/WriteStreamSQLite.h 69.54% <100.00%> (+0.35%) ⬆️
src/ast/transform/SemanticChecker.cpp 96.71% <0.00%> (ø)
src/ast/transform/SubsumptionQualifier.h 50.00% <0.00%> (ø)
src/ast/transform/SubsumptionQualifier.cpp 100.00% <0.00%> (ø)
src/interpreter/Engine.cpp 89.97% <0.00%> (+0.02%) ⬆️
src/main.cpp 68.07% <0.00%> (+0.09%) ⬆️
...ouffle/datastructure/ConcurrentInsertOnlyHashMap.h 90.90% <0.00%> (+1.81%) ⬆️
src/parser/ParserUtils.cpp 77.50% <0.00%> (+2.50%) ⬆️
src/ast/utility/Utils.cpp 91.47% <0.00%> (+3.41%) ⬆️
... and 2 more

Copy link
Member

@b-scholz b-scholz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@b-scholz b-scholz merged commit 592605c into souffle-lang:master Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants