Fixed clang support #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… compilers may be used.
psubotic
added a commit
that referenced
this pull request
Oct 10, 2016
Kostyantyn changes -- Refactoring of the JNI interface build
65linesofcode
pushed a commit
to 65linesofcode/souffle
that referenced
this pull request
Feb 7, 2018
Added a hash-based relation implementation option
azreika
referenced
this pull request
in azreika/souffle
Feb 25, 2019
Add syntax to make record constructors have type information
b-scholz
pushed a commit
that referenced
this pull request
Apr 22, 2019
Add support for an arbitrary number of args for max, min and cat + Clang-format
strRM
added a commit
to strRM/souffle
that referenced
this pull request
Nov 13, 2024
There is a bug souffle-lang#2426, which causes an assertion in the SelingerProfileSipsMetric::getReordering. In our use case we cannot fail the compilation, if as long as the datalog is valid. So, rather than fixing the problem I decided to work-around it for the time being, until we have a proper fix. We can work around this problem in one of two ways: 1. don't assert and just don't reorder atoms (this should be fine) 2. don't create the metric in the first place, if there is no profile I decided to use souffle-lang#2 as that seems to be the safer option. A warning is printed if the scheduler cannot be used.
strRM
added a commit
to strRM/souffle
that referenced
this pull request
Nov 13, 2024
There is a bug souffle-lang#2426, which causes an assertion in the SelingerProfileSipsMetric::getReordering. In our use case we cannot fail the compilation, if as long as the datalog is valid. So, rather than fixing the problem I decided to work-around it for the time being, until we have a proper fix. We can work around this problem in one of two ways: 1. don't assert and just don't reorder atoms (this should be fine) 2. don't create the metric in the first place, if there is no profile I decided to use souffle-lang#2 as that seems to be the safer option. A warning is printed if the scheduler cannot be used.
strRM
added a commit
to strRM/souffle
that referenced
this pull request
Nov 13, 2024
There is a bug souffle-lang#2426, which causes an assertion in the SelingerProfileSipsMetric::getReordering. Rther than fixing the problem I decided to work-around it for the time being, until we have a proper fix. We can work around this problem in one of two ways: 1. don't assert and just don't reorder atoms (this should be fine) 2. don't create the metric in the first place, if there is no profile I decided to use souffle-lang#2 as that seems to be the safer option. I added code for a warning, but disabled it because it is incompatible with the ctest suite.
strRM
added a commit
to strRM/souffle
that referenced
this pull request
Nov 13, 2024
There is a bug souffle-lang#2426, which causes an assertion in the SelingerProfileSipsMetric::getReordering. Rther than fixing the problem I decided to work-around it for the time being, until we have a proper fix. We can work around this problem in one of two ways: 1. don't assert and just don't reorder atoms (this should be fine) 2. don't create the metric in the first place, if there is no profile I decided to use souffle-lang#2 as that seems to be the safer option. I added code for a warning, but disabled it because it is incompatible with the ctest suite.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed clang compiler errors and warnings tolerated by gcc -- now both compilers may be used.