Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Auto-Scheduler #2 #2289

Merged
merged 3 commits into from
Jun 20, 2022
Merged

Refactor Auto-Scheduler #2 #2289

merged 3 commits into from
Jun 20, 2022

Conversation

SamArch27
Copy link
Collaborator

This PR moves the SIPS into ast2ram and refactors the getClauseAtomName(...) dependency into ast2ram/utility/Utils.cpp

TODO in the next PR:

  • Create a SIP Graph data structure
  • Make JoinSizeAnalysis and SelingerSIPS rely on the SIP Graph data structure

@codecov
Copy link

codecov bot commented Jun 19, 2022

Codecov Report

Merging #2289 (1f7f0ab) into master (8979bdf) will increase coverage by 0.12%.
The diff coverage is 80.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2289      +/-   ##
==========================================
+ Coverage   77.17%   77.29%   +0.12%     
==========================================
  Files         458      458              
  Lines       29159    29102      -57     
==========================================
- Hits        22504    22495       -9     
+ Misses       6655     6607      -48     
Impacted Files Coverage Δ
src/ast/analysis/JoinSize.h 100.00% <ø> (ø)
src/ast2ram/seminaive/ClauseTranslator.h 100.00% <ø> (ø)
src/ast2ram/utility/SipsMetric.h 30.00% <ø> (ø)
src/ast2ram/utility/TranslatorContext.cpp 97.41% <ø> (ø)
src/ast2ram/utility/SipsMetric.cpp 53.71% <31.25%> (ø)
src/ast/analysis/JoinSize.cpp 75.43% <100.00%> (+4.60%) ⬆️
src/ast2ram/seminaive/ClauseTranslator.cpp 97.84% <100.00%> (-0.12%) ⬇️
src/ast2ram/utility/Utils.cpp 79.36% <100.00%> (+17.60%) ⬆️
src/include/souffle/utility/ParallelUtil.h 85.27% <0.00%> (+1.55%) ⬆️

Copy link
Member

@b-scholz b-scholz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for refactoring!

@b-scholz b-scholz merged commit ee08ce3 into souffle-lang:master Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants