Update to use read_or_list_full #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taldcroft
reviewed
Sep 21, 2023
2 tasks
jeanconn
changed the title
taldcroft
approved these changes
Sep 25, 2023
Merged
2 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update to use read_or_list_full
Interface impacts
Testing
Tested with ska3-flight 2023.7 from /proj/sot/ska3/test . Also included hopper in PYTHONPATH with sot/hopper#25 .
Unit tests
Independent check of unit tests by [REVIEWER NAME]
Functional tests
Run with HEAD ska3/test + hopper PR 25 at https://icxc.cfa.harvard.edu/aspect/test_review_outputs/starcheck-pr430/sep1823_test.html
Run with HEAD ska3/test installed starcheck and default pythonpath at https://icxc.cfa.harvard.edu/aspect/test_review_outputs/starcheck-pr430/sep1823_2023.7.html
Diff at https://icxc.cfa.harvard.edu/aspect/test_review_outputs/starcheck-pr430/diff.html -- shows no diffs in output. The only diff is the lack of FutureWarnings in the console output.