Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use parse_cm.read_or_list_full #25

Merged
merged 4 commits into from
Sep 25, 2023
Merged

Update to use parse_cm.read_or_list_full #25

merged 4 commits into from
Sep 25, 2023

Conversation

jeanconn
Copy link
Contributor

@jeanconn jeanconn commented Sep 21, 2023

Description

Update to use parse_cm.read_or_list_full

Interface impacts

Testing

Tested with the 2023.7 ska3-flight release that includes a read_or_list FutureWarning from parse_cm.

Unit tests

  • Linux

Independent check of unit tests by [REVIEWER NAME]

  • [PLATFORM]:

Functional tests

Confirmed unit tests hit the FutureWarning and this warning shows up with master but not this PR

hopper/tests/test_hopper.py::test_nov0512_as_planned
  /proj/sot/ska/jeanproj/git/hopper/hopper/spacecraft.py:320: FutureWarning: read_or_list is deprecated and will be removed, use read_or_list_full instead
    obsreqs = parse_cm.read_or_list(or_list)

Confirmed no FutureWarning when run with starcheck sot/starcheck#430 to do a recent week.

@jeanconn jeanconn changed the title WIP: Update to use parse_cm.read_or_list_full Update to use parse_cm.read_or_list_full Sep 24, 2023
@jeanconn jeanconn requested a review from taldcroft September 24, 2023 15:54
Copy link
Member

@taldcroft taldcroft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeanconn jeanconn merged commit 42ed8fd into master Sep 25, 2023
@jeanconn jeanconn deleted the read_or_list branch September 25, 2023 13:09
@javierggt javierggt mentioned this pull request Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants