Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ska3-matlab 2024.8
This PR includes the following changes to bring ska3-matlab in sync with ska3-flight 2024.7 and an update to fot-matlab:
starcheck:
kadi
agasc
ska_sync
fot-matlab
Diffs from last ska3-matlab release
Interface Impacts:
full_agasc
toagasc.write_agasc()
. If true (default), require exactly the standard AGASC column names and dtypes. If false, ensure that the output columns are a strict subset of the standard AGASC columns.columns
inagasc.get_agasc_cone
Testing:
Testing results:
NOTE: some intermittent failures in find_attitude unit tests have been observed. There is a fix for intermittent test failures in find_attitude when using AGASC 1.8 and the 1.7 version of the distances file (sot/find_attitude#30). The issue is of no concern for operations, and the fix will be included in a future release.
The latest release candidates will be installed in
/proj/sot/ska3/matlab/test
on GRETA,and all release candidates will be available for testing from the usual channels:
Review
All operations critical or impacting PR's are independently and carefully reviewed. For other PR's the level of detail for review is calibrated to operations criticality. Some PR's that are confined to aspect-team-specific processing may have little to no independent review.
Deployment
ska3-matlab 2024.8 will be promoted to flight conda channel and installed on GRETA Linux after approval from FOT team.
Code changes
ska3-matlab changes (2024.6 -> 2024.8rc2)
Updated Packages
columns
key inget_agasc_cone
and improve cachingget_starcats
, refactor get_agasc_cone_fast()ska3-core changes (2024.5 -> 2024.7)
Updated Packages (Linux)
Related Issues
Fixes #1382
Fixes #1379