Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin proseco agasc to 1p7 for mag clip test #398

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Conversation

jeanconn
Copy link
Contributor

Description

Set the mag clip test to use the proseco 1p7 agasc.

Fixes test not passing with proseco 1p8.

Interface impacts

Testing

Used /proj/sot/ska/data/agasc/rc as AGASC_DIR with "live" agasc 1p8 files.

Unit tests

  • Linux
ska3-jeanconn-fido> echo $AGASC_DIR
/proj/sot/ska/data/agasc/rc
ska3-jeanconn-fido> git rev-parse HEAD
d2edab9691c4ae84776a8ab53d0a7dec1e74eb33
ska3-jeanconn-fido> pytest
============================================================== test session starts ===============================================================
platform linux -- Python 3.11.8, pytest-7.4.4, pluggy-1.4.0
rootdir: /proj/sot/ska/jeanproj/git
configfile: pytest.ini
plugins: anyio-4.3.0, timeout-2.2.0
collected 167 items                                                                                                                              

proseco/tests/test_acq.py .....................................                                                                            [ 22%]
proseco/tests/test_catalog.py ..........................................                                                                   [ 47%]
proseco/tests/test_core.py ...........................                                                                                     [ 63%]
proseco/tests/test_diff.py ......                                                                                                          [ 67%]
proseco/tests/test_fid.py ...............                                                                                                  [ 76%]
proseco/tests/test_guide.py ....................................                                                                           [ 97%]
proseco/tests/test_mon_full_cat.py ....                                                                                                    [100%]

======================================================== 167 passed in 122.61s (0:02:02)

Independent check of unit tests by [REVIEWER NAME]

  • [PLATFORM]:

Functional tests

No functional testing.

Copy link
Member

@taldcroft taldcroft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jeanconn jeanconn merged commit 2325ec0 into master Jun 21, 2024
2 checks passed
@jeanconn jeanconn deleted the mag-clip-pin-1p7 branch June 21, 2024 18:12
@javierggt javierggt mentioned this pull request Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants