**[insights]** Removing insights-client command as it's superfluous

[PaulWay]

The insights-client command should not be run within sosreport,
as it collects data sosreport already collects and is not cautious
about how it does so. Running it is therefore superfluous.

Closes: #2508
Resolves: #2508

Signed-off-by: Paul Wayper [email protected]

---

Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

• Is the commit message split over multiple lines and hard-wrapped at 72 characters?
• Is the subject and message clear and concise?
• Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
• Does the commit contain a Signed-off-by: First Lastname [email protected]?
• If this commit closes an existing issue, is the line Closes: #ISSUENUMBER included in an independent line?
• If this commit resolves an existing pull request, is the line Resolves: #PRNUMBER included in an independent line?

[TurboTurtle]

We really need to hash out what the future looks like. This was added about a year ago at the request of the Insights team. Since then there's been some discussion about a better way to collect this or similar information for Insights (a few talks with miclark and csams), some kicked off from the very issue this is being removed for; nothing prevents running commands that load kmods or otherwise makes system changes.

I'm fine with removing this collection, but I'd like us to explore the different approaches to still being able to provide Insights with the data that it needs that is missing from any given release of sos.

Please note though, the commit message itself is what needs to be formatted per the contrib guidelines not the PR message (i.e. the closes/resolves tags and such, not the checklist). If you have a moment please copy those bits over to an amended commit message, otherwise I can take care of it when I go to merge this.

[PaulWay]

Hi there,
Last time I looked, the Insights client still had the ability to read a sosreport. It may not have every command in exactly the same format, but it'll give the user 90% of what they want. We can check with Chris Sams to see what it needs, but that should not be the concern of sosreport.

If the Insights client needs to read something specific from a sosreport I would advise them to submit their own PRs to add those commands, and have each request judged on its own merit.

Hope this helps,

Paul