Skip to content

Commit

Permalink
[insights] Removeinsights-client command as it's superfluous
Browse files Browse the repository at this point in the history
The insights-client command should not be run within sosreport,
as it collects data sosreport already collects and is not cautious
about how it does so. Running it is therefore superfluous.

Closes: #2508
Resolves: #2509

Signed-off-by: Paul Wayper <[email protected]>
Signed-off-by: Jake Hunsaker <[email protected]>
  • Loading branch information
PaulWay authored and TurboTurtle committed Apr 26, 2021
1 parent f3f70ab commit 652d118
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions sos/report/plugins/insights.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,6 @@ def setup(self):
else:
self.add_copy_spec("/var/log/insights-client/insights-client.log")

# Collect insights-client report data into given dump dir
path = self.get_cmd_output_path(name="insights-client-dump")
self.add_cmd_output("insights-client --offline --output-dir %s" % path,
suggest_filename="insights-client-dump.log")

def postproc(self):
for conf in self.config:
self.do_file_sub(
Expand Down

0 comments on commit 652d118

Please sign in to comment.