[travis] robustness, actually fail on errors #1603
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a quick mockup of other changes I think we need to capture.. |
|
Where are you seeing build breaks? Master looks OK to me according to current results, and I'm seeing a green light on the home page. |
|
OK, I'm with you now. Errors that don't currently cause a break. |
BryanQuigley
force-pushed
the
travis-robust
branch
2 times, most recently
from
b69e977 to
4123955
Compare
This makes sure if we get errors (anything to stderr) in the build it gets flagged. Today, it can be easily silently ignored. Current build is broken by recent lgtm pull. 3.4 python also appears to be broken by an unneeded call out of the chunksize when threading plugins landed. According to the docs it defaults to 1. Signed-off-by: Bryan Quigley <[email protected]>
BryanQuigley
force-pushed
the
travis-robust
branch
from
4123955 to
81da0d1
Compare
|
fixed the python3.4 build now. thanks for the fixes to the collect errors. all green now and more robust |
bmr-cymru
approved these changes
Mar 26, 2019
bmr-cymru
pushed a commit
that referenced
this pull request
Mar 26, 2019
3.4 python also appears to be broken by an unnecessary use of the chunksize argument when threading plugins landed. According to the docs it defaults to 1, and has no effect for the ThreadPoolExecutor class: "For very long iterables, using a large value for chunksize can significantly improve performance compared to the default size of 1. With ThreadPoolExecutor, chunksize has no effect." Related: #1603 Signed-off-by: Bryan Quigley <[email protected]> Signed-off-by: Bryn M. Reeves <[email protected]>
|
I split this up into two patches, as the changes are not really related in any way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure if we get errors (anything to stderr) in the build
it gets flagged. Today, it can be easily silently ignored.
Current build is broken by recent lgtm pull.
3.4 python also appears to be broken by something else.
Signed-off-by: Bryan Quigley [email protected]
Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines