[travis/sosreport] robustness, actually fail on errors

This makes sure if we get errors (anything to stderr) in the build
it gets flagged.  Today, it can be easily silently ignored.

Current build is broken by recent lgtm pull.

3.4 python also appears to be broken by an unneeded call out of the
chunksize when threading plugins landed.  According to the docs it
defaults to 1.

Signed-off-by: Bryan Quigley <[email protected]>

.travis.yml

@@ -26,6 +26,9 @@ script:
   - "nosetests -v --with-cover --cover-package=sos --cover-html"
   - "sudo ~/virtualenv/python$TRAVIS_PYTHON_VERSION/bin/python ./sosreport --help"
   - "sudo ~/virtualenv/python$TRAVIS_PYTHON_VERSION/bin/python ./sosreport -l --config-file=sos.conf"
-  - "sudo ~/virtualenv/python$TRAVIS_PYTHON_VERSION/bin/python ./sosreport -n kernel --batch --config-file=sos.conf | tee batch_output"
+  - "sudo ~/virtualenv/python$TRAVIS_PYTHON_VERSION/bin/python ./sosreport --batch --config-file=sos.conf 2> errors | tee batch_output"
+  - "[[ ! -s errors ]]"
+  - "cat errors"
+  - "sudo ~/virtualenv/python$TRAVIS_PYTHON_VERSION/bin/python ./sosreport --batch --build --config-file=sos.conf"
 git:
   depth: 5

sos/sosreport.py

@@ -971,7 +971,7 @@ def collect(self):
             self.plugpool = ThreadPoolExecutor(self.opts.threads)
             # Pass the plugpool its own private copy of self.pluglist
             results = self.plugpool.map(self._collect_plugin,
-                                        list(self.pluglist), chunksize=1)
+                                        list(self.pluglist))
             self.plugpool.shutdown(wait=True)
             for res in results:
                 if not res: