-
Notifications
You must be signed in to change notification settings - Fork 666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "[wol] Implement wol command line utility" #3515
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1e81310.
lizhijianrd
reviewed
Sep 3, 2024
doc/Command-Reference.md
Outdated
@@ -222,8 +222,6 @@ | |||
* [Static DNS Commands](#static-dns-commands) | |||
* [Static DNS config command](#static-dns-config-command) | |||
* [Static DNS show command](#static-dns-show-command) | |||
* [Wake-on-LAN Commands](#wake-on-lan-commands) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should keep these doc.
Only revert the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, will save the doc
#3516
lizhijianrd
previously approved these changes
Sep 3, 2024
Save doc for WoL CLI
lizhijianrd
approved these changes
Sep 3, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-utilities
that referenced
this pull request
Dec 12, 2024
* Revert "[wol] Implement wol command line utility (sonic-net#3048)" This reverts commit 1e81310. * Save doc
Cherry-pick PR to 202405: #3677 |
mssonicbld
pushed a commit
that referenced
this pull request
Dec 12, 2024
mssonicbld
added
Included in 202405 Branch
and removed
Created PR to 202405 Branch
labels
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we use compiled wol cli in and after 202411: sonic-net/sonic-buildimage#19206
So, we reverts PR #3048