Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[acl_loader] Support Service ACL binding to multiple services #236

Merged
merged 2 commits into from
Apr 10, 2018
Merged

[acl_loader] Support Service ACL binding to multiple services #236

merged 2 commits into from
Apr 10, 2018

Conversation

jleveque
Copy link
Contributor

@jleveque jleveque commented Apr 10, 2018 •
edited
Loading

Sample new output of acl-loader show table

admin@sonic:~$ acl-loader show table
Name            Type       Binding      Description
--------------  ---------  -----------  --------------
EVERFLOW        MIRROR     Ethernet0    EVERFLOW
                           Ethernet4
                           Ethernet8
                           Ethernet12
                           Ethernet16
ROUTER_PROTECT  CTRLPLANE  SNMP         ROUTER_PROTECT
                           SSH
DATAACL         L3         Ethernet0    DATAACL
                           Ethernet4
                           Ethernet8
                           Ethernet12
                           Ethernet16

@jleveque jleveque self-assigned this Apr 10, 2018
@jleveque jleveque requested a review from lguohan April 10, 2018 01:37
@jleveque jleveque mentioned this pull request Apr 10, 2018
Merged
@lguohan
Copy link
Contributor

lguohan commented Apr 10, 2018

@jleveque , can you add sample output?

@jleveque jleveque merged commit 5e476d6 into sonic-net:master Apr 10, 2018
@jleveque jleveque deleted the service_acls_same_name branch April 10, 2018 21:44
zhenggen-xu added a commit to zhenggen-xu/sonic-utilities that referenced this pull request Jun 6, 2018
@zhenggen-xu
Merge branch 'github'
473c9dd 
            RB=1288101
            G=lnos-reviewers
            R=ntrianta,pmao,rmolina,sfardeen,zxu

* github:
  [acl_loader] Support Service ACL binding to multiple services (sonic-net#236)
  [show] Rename 'show session' to 'show mirror session' (sonic-net#235)
  [pfcstat]: create python cli tool to show pfc counters (sonic-net#233)
  [queuestat] add python CLI tool to show queue counters
  [acl-loader] Not to crash upon invalid rule (sonic-net#232)
  Show FDB type in fdbshow/show mac (sonic-net#231)
  [show] add 'show runningconfiguration all' subcommand (sonic-net#230)
  [reboot scripts] remove -t option in docker exec commands (sonic-net#228)
  [reboot] reduce stop service to only stop syncd (sonic-net#223)
  [crm]: Fix failures in CLI show commands (sonic-net#221)
  [Fast-reboot]: Gracefully shutdown syncd in fast-reboot (sonic-net#212)
  add fast-reboot support for nephos platform by stop kernel modules (sonic-net#220)
  [config bgp] Convert user input ipv6 addr to lower case before comparing (sonic-net#218)
  [PFCWD]: set default configuration when enabled by default (sonic-net#213)
  Add fast-reboot support for Aboot based images (sonic-net#214)
  sonic-utilities: Format show vlan config output (sonic-net#210)
  [AAA] Support login(ascii) authentication type (sonic-net#217)
  [sfputil] Adapt new way of getting PLATFORM(sonic-net#216)
  [Fast-Reboot]: Adapt fast-reboot-dump script for SAIv1.2  (sonic-net#211)
  Refactor fast-reboot script. Generate fast-reboot-dumps into configurable directory (sonic-net#208)
  Find correct opennsl module name before stopping it (sonic-net#207)
  [crm]: Add utility for CRM configuration (sonic-net#187)
  [reboot] update reboot script to retrieve platform with new format (sonic-net#206)
  Adapt to config engine change to load platform info properly (sonic-net#205)
  [config] Add qos clear and qos reload support (sonic-net#204)
  Dump default routes from APPL_DB table before fast-reboot (sonic-net#203)
  [acl_loader] Fix a crash issue when appdb is not consistent with cfgdb (sonic-net#202)
  [pfcwd]: add command to set pfcwd polling interval (sonic-net#192)
  [acl-loader] Prevent from hanging if run by non-root user (sonic-net#199)
  [config] Store ConfigDB init indicator boolean value as 1/0 in Redis to be language-agnostic (sonic-net#197)
  Get Vlan Id from SAI Vlan Object if bvid present (sonic-net#196)
  [TACACS+]: Fix aaa show error without configuration (sonic-net#191)
  'config bgp [shutdown|startup] neighbor <hostname>' now affects all sessions for neighbor (sonic-net#195)
  [sonic-clear] add a clear fdb command (sonic-net#186)
mihirpat1 pushed a commit to mihirpat1/sonic-utilities that referenced this pull request Sep 15, 2023
@sujinmkang
Enable code diff coverage in sonic-platform-common repo (sonic-net#236)
a2e6232 
Description
Enable 50% diff coverage in sonic-platform-common repo

Motivation and Context
Enhance the code quality
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lguohan lguohan lguohan approved these changes

Assignees

@jleveque jleveque

Labels
acl-loader/aclshow Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jleveque @lguohan