[PFCWD]: set default configuration when enabled by default #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sihui Han <[email protected]>
sihuihan88
force-pushed
the
dev/sihan/enable
branch
from
1a0c235 to
2b9f40b
Compare
lguohan
reviewed
Mar 2, 2018
pfcwd/main.py
Outdated
|
|
||
| for port in vlan_members: | ||
| configdb.mod_entry("PFC_WD_TABLE", port, None) | ||
| configdb.mod_entry("PFC_WD_TABLE", port, pfcwd_info) |
There was a problem hiding this comment.
set_entry will remove extra fields. use set_entry instead of mod_entry.
lguohan
reviewed
Mar 2, 2018
pfcwd/main.py
Outdated
|
|
||
| pfcwd_info = { | ||
| 'detection_time': DEFAULT_DETECTION_TIME * max(port_num/DEFAULT_PORT_NUM, 1), | ||
| 'restoration_time': DEFAULT_RESTORATION_TIME * max(port_num/DEFAULT_PORT_NUM, 1), |
There was a problem hiding this comment.
let's not do the calculation here, just use the DEFAULT_DETECTION_TIME. The reason is that the detection time is based on external network requirement, it should not be set based on the port num in the system.
lguohan
reviewed
Mar 2, 2018
pfcwd/main.py
Outdated
| 'action': DEFAULT_ACTION | ||
| } | ||
|
|
||
| for port in vlan_members: |
There was a problem hiding this comment.
using vlan to determine whether the port is connected to server is the last resort, should use neighbor table first. check this commit.
There was a problem hiding this comment.
I checked the above commit and I believe it also uses vlan to determine the server facing port as we don't have neighbor table for servers.
lguohan
reviewed
Mar 2, 2018
| DEFAULT_DETECTION_TIME = 200 | ||
| DEFAULT_RESTORATION_TIME = 200 | ||
| DEFAULT_POLL_INTERVAL = 200 | ||
| DEFAULT_PORT_NUM = 32 |
Signed-off-by: Sihui Han <[email protected]>
lguohan
approved these changes
Mar 3, 2018
zhenggen-xu
added a commit
to zhenggen-xu/sonic-utilities
that referenced
this pull request
Jun 6, 2018
RB=1288101
G=lnos-reviewers
R=ntrianta,pmao,rmolina,sfardeen,zxu
* github:
[acl_loader] Support Service ACL binding to multiple services (sonic-net#236)
[show] Rename 'show session' to 'show mirror session' (sonic-net#235)
[pfcstat]: create python cli tool to show pfc counters (sonic-net#233)
[queuestat] add python CLI tool to show queue counters
[acl-loader] Not to crash upon invalid rule (sonic-net#232)
Show FDB type in fdbshow/show mac (sonic-net#231)
[show] add 'show runningconfiguration all' subcommand (sonic-net#230)
[reboot scripts] remove -t option in docker exec commands (sonic-net#228)
[reboot] reduce stop service to only stop syncd (sonic-net#223)
[crm]: Fix failures in CLI show commands (sonic-net#221)
[Fast-reboot]: Gracefully shutdown syncd in fast-reboot (sonic-net#212)
add fast-reboot support for nephos platform by stop kernel modules (sonic-net#220)
[config bgp] Convert user input ipv6 addr to lower case before comparing (sonic-net#218)
[PFCWD]: set default configuration when enabled by default (sonic-net#213)
Add fast-reboot support for Aboot based images (sonic-net#214)
sonic-utilities: Format show vlan config output (sonic-net#210)
[AAA] Support login(ascii) authentication type (sonic-net#217)
[sfputil] Adapt new way of getting PLATFORM(sonic-net#216)
[Fast-Reboot]: Adapt fast-reboot-dump script for SAIv1.2 (sonic-net#211)
Refactor fast-reboot script. Generate fast-reboot-dumps into configurable directory (sonic-net#208)
Find correct opennsl module name before stopping it (sonic-net#207)
[crm]: Add utility for CRM configuration (sonic-net#187)
[reboot] update reboot script to retrieve platform with new format (sonic-net#206)
Adapt to config engine change to load platform info properly (sonic-net#205)
[config] Add qos clear and qos reload support (sonic-net#204)
Dump default routes from APPL_DB table before fast-reboot (sonic-net#203)
[acl_loader] Fix a crash issue when appdb is not consistent with cfgdb (sonic-net#202)
[pfcwd]: add command to set pfcwd polling interval (sonic-net#192)
[acl-loader] Prevent from hanging if run by non-root user (sonic-net#199)
[config] Store ConfigDB init indicator boolean value as 1/0 in Redis to be language-agnostic (sonic-net#197)
Get Vlan Id from SAI Vlan Object if bvid present (sonic-net#196)
[TACACS+]: Fix aaa show error without configuration (sonic-net#191)
'config bgp [shutdown|startup] neighbor <hostname>' now affects all sessions for neighbor (sonic-net#195)
[sonic-clear] add a clear fdb command (sonic-net#186)
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 18, 2022
…aemons (#8607) This PR updates the following commits in sonic-platform-common 9d2e7d5 Add y-cable driver for simulated mux (sonic-net#213) e3e8f09 [Y-Cable][Broadcom] Broadcom implementation of YCable class which inherits from YCableBase required for Y-Cable API's in sonic-platform-daemons (sonic-net#208) This PR updates the following commits in sonic-platform-daemons ebc4f3f [Y-Cable] create unknown entries for mux_cable when there is a cable present but module definition is not present/invalid module b10c417 [xcvrd] initial support for integrating vendor specfic class objects for calling Y-Cable API's inside xcvrd (sonic-net#197) (sonic-net#213) f3fc1ea [y-cable] fix for logging the xcvrd metrics before writing the state to the State-DB (sonic-net#208) Signed-off-by: vaibhav-dahiya <[email protected]>
mihirpat1
pushed a commit
to mihirpat1/sonic-utilities
that referenced
this pull request
Sep 15, 2023
Description This PR added y-cable driver for simulated mux. This y-cable driver conforms with the requirement of https://github.com/Azure/SONiC/pull/757/files Motivation and Context After the abstract y-cable base class is added for multi-vendor y-cable support, we also need a y-cable driver for simulated mux used in lab testing. How Has This Been Tested? Update the xcvrd package in pmon docker to include the changes in [xcvrd] initial support for integrating vendor specfic class objects for calling Y-Cable API's inside xcvrd sonic-platform-daemons#197 Update the sonic_y_cable package in pmon docker to include the changes in this PR. Create /etc/sonic/config_db.json on DUT. Restart the pmon docker. Run some dualtor test scripts. Check mux status on dualtor testbed. Signed-off-by: Xin Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sihui Han [email protected]
- What I did
Set default configuration when enabled by default
- How I did it
Implement the pfcwd start_default function to set default configuration.
- How to verify it
Test on DUT
- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)
-->