[sonic-installer] use host docker startup arguments when running dockerd in chroot #2179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erd in chroot Signed-off-by: Stepan Blyschak <[email protected]>
…o fix-installer-on-multi-asic
Signed-off-by: Stepan Blyschak <[email protected]>
|
@abdosi appreciate if you can also take further look at the coverage report. |
Signed-off-by: Stepan Blyschak <[email protected]>
abdosi
approved these changes
May 27, 2022
6 tasks
This was referenced Jun 9, 2022
|
@gechiang please help take a look why this is not taken in 202205 branch yet. |
|
@stepanblyschak , this PR cannot be cleanly cherry-picked into 202205 branch. Can you please raise a new PR in 202205 branch and port this over? On the new PR please tag me and @abdosi for review. |
|
@stepanblyschak this change cannot be cherry-picked cleanly to 202205, please raise separate PR. |
liat-grozovik
pushed a commit
that referenced
this pull request
Oct 3, 2022
…erd in chroot (#2179) (#2407) Backport of #2179 - Why I did it I attempted to fix an issue that happens on multi-asic devices after new SONiC image installation. The issue is caused by overriding docker0 bridge configuration as well as installing iptables rules by dockerd started in chroot environment. Fixes sonic-net/sonic-buildimage#10135 - How I did it I start dockerd in chroot using same parameters the host dockerd is started with. - How to verify it Run VS multi-asic device. Install a new image on it. Verify "show version", "show interface status" Signed-off-by: Stepan Blyschak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
I attempted to fix an issue that happens on multi-asic devices after new SONiC image installation. The issue is caused by overriding docker0 bridge configuration as well as installing iptables rules by dockerd started in chroot environment.
Fixes sonic-net/sonic-buildimage#10135
How I did it
I start dockerd in chroot using same parameters the host dockerd is started with.
How to verify it
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)