Image-installer: Fix duplication of image prefix #2172
Conversation
|
@stepanblyschak please review |
|
@stepanblyschak i am un able to assign you as a reviewer so sending a reminder :-) thanks. |
* SONiC prefix shown twice when working branch contains "image-" in its name. Signed-off-by: Yevhen Fastiuk <[email protected]>
* Fix conversion of image name/folder to image id that replaces all occurrences of that prefix (image-). Buggy behavior: Name: image-dev-SONiC-image-ec0cedd5 -> ID: SONiC-dev-SONiC-SONiC-ec0cedd5 Correct behavior: Name: image-dev-SONiC-image-ec0cedd5 -> ID: SONiC-dev-SONiC-image-ec0cedd5 * Fix reverse conversion of image id to image folder/name that replaces all occurrences of that prefix (SONiC-). Buggy behavior: ID: SONiC-dev-SONiC-image-ec0cedd5 -> Name: image-dev-image-image-ec0cedd5 Correct behavior: ID: SONiC-dev-SONiC-image-ec0cedd5 -> Name: image-dev-SONiC-image-ec0cedd5
Signed-off-by: Yevhen Fastiuk <[email protected]>
fastiuk
force-pushed
the
fix-image-installer-prefix
branch
from
005d3ac to
d0292c4
Compare
|
Is this a regression? If yes, which change introduced regression? What platform(s) are impacted? I didn't see this issue with 202205 image, is this issue platform specific? if not, why is it needed for 202205? |
@yxieca I think this is a zero-day issue. At least I investigated so from git history. |
@fastiuk, I think you have some image that we built, like the ones used for factory default image. I don't observe this issue on these images. Nor did I see this issue before. I am not convinced it is a zero-day issue. I am wondering if this change would cause issue on platforms that wasn't subject to this issue before? |
|
Discussed with Qi. This is a very specific corner case. |
|
This is a good change. But I don't think we need to cherry-pick it to a feature branch. The corner case is very specific. |
contains "image-" in its name.
Signed-off-by: Yevhen Fastiuk [email protected]
Why I did it
SONiC prefix is shown twice when the working branch contains "image-" in its name.
How I did it
Fixed sonic-installer's one bootloader wrapper to show correct version.
How to verify it
Build image (the branch is important):
Run image on the switch and execute:
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)