Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[platform/broadcom] Celeatica Silverstone add IPMI platform sensor read. #3591

Merged
merged 2 commits into from
Nov 8, 2019
Merged

[platform/broadcom] Celeatica Silverstone add IPMI platform sensor read. #3591

merged 2 commits into from
Nov 8, 2019

Conversation

pphuchar
Copy link
Contributor

@pphuchar pphuchar commented Oct 11, 2019 •
edited
Loading

- What I did

Add the script to display platform sensors from BMC using IPMI.
The Fans, PSUs, and temperature sensors are displayed.

- How I did it

  • Add the script to read BMC sensor using ipmitool in pmon docker.
  • Append original sensors script with platform sensor reading.
  • Update platform module install script to overlay the original sensors script.

- How to verify it
run the show environment command to display platform sensors. Fans, PSUs, and Temperature sensors must show up.

- Description for the changelog

  • Add platform sensor reading on Silverstone device.

- A picture of a cute animal (not mandatory but encouraged)

@pphuchar
Copy link
Contributor Author

pphuchar commented Oct 11, 2019 •
edited
Loading

Test log

admin@sonic:~$ show environment 
coretemp-isa-0000
Adapter: ISA adapter
Physical id 0:  +44.0 C  (high = +82.0 C, crit = +104.0 C)
Core 0:         +44.0 C  (high = +82.0 C, crit = +104.0 C)
Core 1:         +44.0 C  (high = +82.0 C, crit = +104.0 C)

Temperature Sensors
Adapter: IPMI adapter
Fan Tray Middle Temp:         29 degrees C
Fan Tray Right Temp:          26 degrees C
Switchboard Left Inlet Temp:  26 degrees C
Switchboard Right Inlet Temp: 25 degrees C
Baseboard Temp:               27 degrees C
CPU Internal Temp:            40 degrees C
ASIC Internal Temp:           44 degrees C
IR3595 Chip Left Temp:        29 degrees C
IR3595 Chip Right Temp:       23 degrees C
IR3584 Chip Temp:             41 degrees C

PSU
Adapter: IPMI adapter
PSU 1 Status:          Presence detected
PSU 1 Fan:             16000 RPM
PSU 1 Input Voltag:    231 Volts
PSU 1 Input Current:   0.56 Amps
PSU 1 Input Power:     138 Watts
PSU 1 Temp1:           27 degrees C
PSU 1 Temp2:           33 degrees C
PSU 1 Output Voltag:   12 Volts
PSU 1 Output Current:  9.50 Amps
PSU 1 Output Power:    114 Watts
PSU 2 Status:          Presence detected
PSU 2 Fan:             16000 RPM
PSU 2 Input Voltag:    231 Volts
PSU 2 Input Current:   0.56 Amps
PSU 2 Input Power:     132 Watts
PSU 2 Temp1:           26 degrees C
PSU 2 Temp2:           36 degrees C
PSU 2 Output Voltag:   12 Volts
PSU 2 Output Current:  9 Amps
PSU 2 Output Power:    108 Watts

Fan Trays
Adapter: IPMI adapter
Status:       Present
Fan 1 front:  12450 RPM
Fan 1 rear:   14850 RPM
Status:       Present
Fan 2 front:  12000 RPM
Fan 2 rear:   14700 RPM
Status:       Present
Fan 3 front:  12000 RPM
Fan 3 rear:   14850 RPM
Status:       Present
Fan 4 front:  12600 RPM
Fan 4 rear:   14700 RPM
Status:       Present
Fan 5 front:  12300 RPM
Fan 5 rear:   15000 RPM
Status:       Present
Fan 6 front:  12300 RPM
Fan 6 rear:   14700 RPM
Status:       Present
Fan 7 front:  12150 RPM
Fan 7 rear:   14700 RPM


admin@sonic:~$

@pphuchar pphuchar force-pushed the silverstone-add-ipmi-sensors branch from 5479398 to 3dc22e1 Compare October 11, 2019 13:53
@pphuchar pphuchar marked this pull request as ready for review October 15, 2019 09:07
@lguohan lguohan merged commit 2e61e14 into sonic-net:master Nov 8, 2019
zhenggen-xu pushed a commit to zhenggen-xu/sonic-buildimage that referenced this pull request Jan 10, 2020
@pphuchar @zhenggen-xu
[devices] Celeatica Silverstone add IPMI platform sensor read. (sonic…
4a7dc3e 
…-net#3591)

* [platform/broadcom] Celeatica Silverstone add IPMI platform sensor read.

* [platform_sensors] Silverstone update temperature sensor description
@pphuchar pphuchar deleted the silverstone-add-ipmi-sensors branch May 13, 2020 12:31
mudsut4ke pushed a commit to mudsut4ke/sonic-buildimage that referenced this pull request Sep 22, 2020
@pphuchar
[devices] Celeatica Silverstone add IPMI platform sensor read. (sonic…
e43b107 
…-net#3591)

* [platform/broadcom] Celeatica Silverstone add IPMI platform sensor read.

* [platform_sensors] Silverstone update temperature sensor description
zhenggen-xu pushed a commit to zhenggen-xu/sonic-buildimage that referenced this pull request Oct 26, 2020
@tiantianlv @ds952811 @pphuchar
[platform/cel]: Add Celestica Silverstone device to 201811 branch (#88)
ab8f79e 
* cherry pick from 368c4fa

* sonic-device-data: update SAI config checker for Broadcom TD3 and TH3 (sonic-net#3107)

* sonic-device-data: update SAI config checker for Broadcom TD3 and TH3

The following properties have been approved by the Broadcom chip arch team:

l3_alpm_ipv6_128b_bkt_rsvd
ifp_inports_support_enable
pll_bypass
dpr_clock_frequency
device_clock_frequency
port_flex_enable
mmu_port_num_mc_queue
serdes_core_rx_polarity_flip_physical{<PORT>}
serdes_core_tx_polarity_flip_physical{<PORT>}

Signed-off-by: Dante (Kuo-Jung) Su <[email protected]>
Change-Id: I1c6239cddfb0582a9298e671d792a32f79e4f006

* [device/celestica]: Add more permitted config for Silverstone bcm config

* [platform/cel]: update linux image version

* [devices] Celeatica Silverstone add IPMI platform sensor read. (sonic-net#3591)

* [platform/broadcom] Celeatica Silverstone add IPMI platform sensor read.

* [platform_sensors] Silverstone update temperature sensor description

* Load port led FW for Silverstone! (sonic-net#4313)

* [device/celestica]: add reboot cause api to silverstone

* [device/celestica]: fix lgtm error

* [device/celestica]: update reboot cause api to silverstone

* [device/celestica]: add pre-emphasis_PAM4_optics config to silverstone

* [sonic-device-data/test]: allow port_fec in permitted_list

* [sonic-device-data]: remove unuse command from permitted_list

* [device/celestica]: fix sfp port name on silverstone device

* [syncd-brcm]: add pre-emphasis load to start.sh

* [device/celestica]: rm rcload cmd on led_proc_init of silverstone

* [syncd-brcm]: update pre-emphasis load in start.sh

* [device/celestica]: remove unuse sleep time in led_proc_init

Co-authored-by: tiantianlv <[email protected]>
Co-authored-by: Dante (Kuo-Jung) Su <[email protected]>
Co-authored-by: Pradchaya Phucharoen <[email protected]>
mssonicbld added a commit that referenced this pull request Oct 24, 2024
@mssonicbld
[submodule] Update submodule sonic-utilities to the latest HEAD autom…
5173783 
…atically (#20597)

#### Why I did it
src/sonic-utilities
```
* 4907fba8 - (HEAD -> 202311, origin/202311) [202311]Set warn msg for list of tables which not covered by YANG (#3591) (3 hours ago) [jingwenxie]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lguohan lguohan lguohan approved these changes

Assignees

@zhenggen-xu zhenggen-xu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pphuchar @lguohan @zhenggen-xu