-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue: unprintable character is rendered when handling comments in j2 #16287
Conversation
…n j2 Use "{#-" and "-#}" to mark comments in jinja template Signed-off-by: Stephen Sun <[email protected]>
@stephenxs to which branches this is needed? master only? |
@liat-grozovik The issue was introduced when the license was added as the file header in PR #16096 which has been back-ported to 202211 only so far. So I added a tag for 202211 only (cleanly cherry-picked based on the latest 202211 commit e7ce179) |
…n j2 (sonic-net#16287) Use "{#-" and "-#}" to mark comments in jinja template Signed-off-by: Stephen Sun <[email protected]>
Cherry-pick PR to 202211: #16421 |
@stephenxs PR conflicts with 202305 branch |
Thanks @mssonicbld |
…n j2 (#16287) Use "{#-" and "-#}" to mark comments in jinja template Signed-off-by: Stephen Sun <[email protected]>
…n j2 (sonic-net#16287) Use "{#-" and "-#}" to mark comments in jinja template Signed-off-by: Stephen Sun <[email protected]>
Use "{#-" and "-#}" to mark comments in jinja template
Why I did it
Work item tracking
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)