Removed extra 'ip addr del' on the lo inteface #15463
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'post-up ip addr del 127.0.0.1/8 dev lo' was thought to be required when the loopback interface subnet mask was narrowed from /8 to /16. After testing first reboot, subsequent reboots, config reloads, and systemctl restart networking on linecards and supevisors (DNX VOQ chassis), this cleanup command does not appear to be required. As such, this change removes it as well as reverts sonic-net#15080.
|
Tagging @saiarcot895 @arlakshm |
|
Had an offline discussion with @saiarcot895. This PR doesn't solve the problem he was originally chasing with respect to uninterrupted connectivity to 127.0.0.1. #15080 is the right solution. Closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
The 'post-up ip addr del 127.0.0.1/8 dev lo' was thought to be required when the loopback interface subnet mask was narrowed from /8 to /16 (#5353). After testing first reboot, subsequent reboots, config reloads, and systemctl restart networking on linecards and supevisors (DNX VOQ chassis), this cleanup command does not appear to be required.
This change removes the delete command as well as reverts #15080.
Work item tracking
How I did it
How to verify it
Confirmed that ssh connections from supervisor to linecards can be established after first boot, subsequent reboots, config reload and systemctl restart networking tampers.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)