[Arista][x86_64-arista_7050_qx32] Add Components to platform.json #15252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vaibhav dahiya <[email protected]>
|
@Staphylo Can you review? |
|
@vdahiya12 can you specify the ADO number in the PR template above? |
added |
Staphylo
reviewed
May 31, 2023
Comment on lines
4
to
20
| "components": [ | ||
| { | ||
| "name": "Aboot()" | ||
| }, | ||
| { | ||
| "name": "Scd(addr=0000:02:00.0)" | ||
| }, | ||
| { | ||
| "name": "Ucd90120A(addr=4-004e)" | ||
| }, | ||
| { | ||
| "name": "Ucd90120A(addr=8-004e)" | ||
| }, | ||
| { | ||
| "name": "CrowSysCpld(addr=2-0023)" | ||
| } | ||
| ], |
There was a problem hiding this comment.
For this product, this is the current list of components:
Scd(addr=0000:04:00.0)
Ucd90120A(addr=6-004e)
Ucd90160(addr=10-004e)
Signed-off-by: vaibhav dahiya <[email protected]>
Staphylo
suggested changes
Jun 2, 2023
| "components": [], | ||
| "components": [ | ||
| { | ||
| "name": "Aboot()" |
There was a problem hiding this comment.
The Aboot component is currently not defined for this product
| "name": "Ucd90160(addr=10-004e)" | ||
| }, | ||
| { | ||
| "name": "CrowSysCpld(addr=2-0023)" |
There was a problem hiding this comment.
This product doesn't have this CrowSysCpld component.
Signed-off-by: vaibhav dahiya <[email protected]>
Signed-off-by: vaibhav dahiya <[email protected]>
Staphylo
approved these changes
Jun 20, 2023
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Jun 22, 2023
…nic-net#15252) * [Arista][x86_64-arista_7050_qx32] Add Components to platform.json Signed-off-by: vaibhav dahiya <[email protected]> * fix comment Signed-off-by: vaibhav dahiya <[email protected]> * fix comment Signed-off-by: vaibhav dahiya <[email protected]> * reformat Signed-off-by: vaibhav dahiya <[email protected]> --------- Signed-off-by: vaibhav dahiya <[email protected]>
|
Cherry-pick PR to 202211: #15584 |
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Jun 22, 2023
…nic-net#15252) * [Arista][x86_64-arista_7050_qx32] Add Components to platform.json Signed-off-by: vaibhav dahiya <[email protected]> * fix comment Signed-off-by: vaibhav dahiya <[email protected]> * fix comment Signed-off-by: vaibhav dahiya <[email protected]> * reformat Signed-off-by: vaibhav dahiya <[email protected]> --------- Signed-off-by: vaibhav dahiya <[email protected]>
|
Cherry-pick PR to 202205: #15585 |
This was referenced Jun 22, 2023
mssonicbld
added a commit
that referenced
this pull request
Jun 22, 2023
mssonicbld
added
Included in 202205 Branch
and removed
Approved for 202205 Branch
Created PR to 202205 Branch
labels
mssonicbld
added a commit
that referenced
this pull request
Jun 22, 2023
mssonicbld
added
Included in 202211 Branch
and removed
Approved for 202211 Branch
Created PR to 202211 Branch
labels
|
Cherry-pick PR to 202305: #15596 |
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Jun 23, 2023
…nic-net#15252) * [Arista][x86_64-arista_7050_qx32] Add Components to platform.json Signed-off-by: vaibhav dahiya <[email protected]> * fix comment Signed-off-by: vaibhav dahiya <[email protected]> * fix comment Signed-off-by: vaibhav dahiya <[email protected]> * reformat Signed-off-by: vaibhav dahiya <[email protected]> --------- Signed-off-by: vaibhav dahiya <[email protected]>
8 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Jun 26, 2023
…5252) * [Arista][x86_64-arista_7050_qx32] Add Components to platform.json Signed-off-by: vaibhav dahiya <[email protected]> * fix comment Signed-off-by: vaibhav dahiya <[email protected]> * fix comment Signed-off-by: vaibhav dahiya <[email protected]> * reformat Signed-off-by: vaibhav dahiya <[email protected]> --------- Signed-off-by: vaibhav dahiya <[email protected]>
mssonicbld
added
Included in 202305 Branch
and removed
Created PR to 202305 Branch
labels
sonic-otn
pushed a commit
to sonic-otn/sonic-buildimage
that referenced
this pull request
Sep 20, 2023
…nic-net#15252) * [Arista][x86_64-arista_7050_qx32] Add Components to platform.json Signed-off-by: vaibhav dahiya <[email protected]> * fix comment Signed-off-by: vaibhav dahiya <[email protected]> * fix comment Signed-off-by: vaibhav dahiya <[email protected]> * reformat Signed-off-by: vaibhav dahiya <[email protected]> --------- Signed-off-by: vaibhav dahiya <[email protected]>
lixiaoyuner
pushed a commit
to lixiaoyuner/sonic-buildimage
that referenced
this pull request
Feb 6, 2024
Highlight change, the DHCP config removed from master branch. files/image_config/resolv-config/resolv.conf Related work items: sonic-net#49, sonic-net#2598, sonic-net#11862, sonic-net#12530, sonic-net#14000, sonic-net#14549, sonic-net#14814, sonic-net#15077, sonic-net#15252, sonic-net#15253, sonic-net#15357, sonic-net#15384, sonic-net#15394, sonic-net#15399, sonic-net#15405, sonic-net#15566, sonic-net#15591, sonic-net#15592, sonic-net#15593, sonic-net#15602, sonic-net#15604, sonic-net#15611, sonic-net#15621, sonic-net#15625, sonic-net#15634, sonic-net#15635
lixiaoyuner
pushed a commit
to lixiaoyuner/sonic-buildimage
that referenced
this pull request
Feb 6, 2024
Merge code from master to internal Related work items: sonic-net#32, sonic-net#49, sonic-net#376, sonic-net#2598, sonic-net#11862, sonic-net#12530, sonic-net#14000, sonic-net#14547, sonic-net#14549, sonic-net#14814, sonic-net#15077, sonic-net#15239, sonic-net#15252, sonic-net#15253, sonic-net#15298, sonic-net#15357, sonic-net#15384, sonic-net#15394, sonic-net#15399, sonic-net#15405, sonic-net#15511, sonic-net#15566, sonic-net#15583, sonic-net#15591, sonic-net#15592, sonic-net#15593, sonic-net#15602, sonic-net#15604, sonic-net#15611, sonic-net#15621, sonic-net#15625, sonic-net#15634, sonic-net#15635, sonic-net#15645, sonic-net#15646, sonic-net#15647, sonic-net#15657, sonic-net#15658, sonic-net#15697, sonic-net#15699
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
This PR fixes the components names and adds the number so that platform API tests can get consistent results to match vs the expected results.
The way to verify /get the platform API results is run the platform API and get the components name for these SKU x86_64-arista_7050_qx32, x86_64-arista_7050_qx32s
Work item tracking
17397061
16428955
How I did it
Run the Platfrom API and get the components names
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)