[dns] Add support for static DNS configuration. #14549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is the re-creation of #14239, which was closed by mistake |
ganglyu
previously approved these changes
Apr 12, 2023
ganglyu
reviewed
Apr 15, 2023
| @@ -0,0 +1,7 @@ | |||
| #!/bin/bash | |||
|
|
|||
| for container in $(docker ps -a --format=" {{ .ID }}"); do | |||
There was a problem hiding this comment.
Some containers like telemetry will start after 3 minutes.
If we upgrade SONiC image, and start the system for the first time, can we update /etc/resolv.conf in telemetry container?
There was a problem hiding this comment.
docker ps -a command returns all existing containers on the system. And we will update /etc/resolv.conf file for all containers including those that are not running.
For the case when the container is created in the runtime (for example app extension), when the dockerd starts the container it copies /etc/resolv.conf file from the host OS into the container filesystem. So, we will always have a valid DNS configuration inside the containers.
oleksandrivantsiv
force-pushed
the
static-dns
branch
from
98861a8 to
42216df
Compare
…working reconfiguration in Linux. (sonic-net#13516)" (sonic-net#14902)" This reverts commit 72c52bc.
oleksandrivantsiv
force-pushed
the
static-dns
branch
from
42216df to
98a1fff
Compare
|
@ganglyu would you please refer to comments and help to approve? |
ganglyu
approved these changes
Jun 14, 2023
Yakiv-Huryk
approved these changes
Jun 22, 2023
liat-grozovik
approved these changes
Jun 22, 2023
dgsudharsan
added a commit
to dgsudharsan/sonic-buildimage
that referenced
this pull request
Jun 30, 2023
)" This reverts commit 475fe27.
dgsudharsan
added a commit
to dgsudharsan/sonic-buildimage
that referenced
this pull request
Jul 5, 2023
)" This reverts commit 475fe27.
vivekrnv
added a commit
to vivekrnv/sonic-buildimage
that referenced
this pull request
Jul 7, 2023
)" This reverts commit 475fe27.
ganglyu
added a commit
to sonic-net/sonic-utilities
that referenced
this pull request
Jul 12, 2023
What I did sonic-net/sonic-buildimage#14549 This PR has introduced DNS configuration to CONFIG_DB, we need to migrate original CONFIG_DB to support DNS configuration during upgrading SONiC. How I did it If there's no DNS_NAMESERVER table in CONFIG_DB, read DNS_NAMESERVER table from minigraph and update CONFIG_DB. How to verify it Run unit test for db migrator.
dgsudharsan
added a commit
to dgsudharsan/sonic-buildimage
that referenced
this pull request
Jul 21, 2023
…c-net#14549)"" This reverts commit 43ca7d3.
rajkumar38
pushed a commit
to rajkumar38/sonic-utilities
that referenced
this pull request
Jul 25, 2023
What I did sonic-net/sonic-buildimage#14549 This PR has introduced DNS configuration to CONFIG_DB, we need to migrate original CONFIG_DB to support DNS configuration during upgrading SONiC. How I did it If there's no DNS_NAMESERVER table in CONFIG_DB, read DNS_NAMESERVER table from minigraph and update CONFIG_DB. How to verify it Run unit test for db migrator.
rajkumar38
pushed a commit
to rajkumar38/sonic-utilities
that referenced
this pull request
Jul 25, 2023
What I did sonic-net/sonic-buildimage#14549 This PR has introduced DNS configuration to CONFIG_DB, we need to migrate original CONFIG_DB to support DNS configuration during upgrading SONiC. How I did it If there's no DNS_NAMESERVER table in CONFIG_DB, read DNS_NAMESERVER table from minigraph and update CONFIG_DB. How to verify it Run unit test for db migrator.
|
@oleksandrivantsiv @ganglyu For me, this looks like a feature other than bug fix, if so, not to 202305. |
|
The feature was discussed for 202305 and hld was available for long time including PRs
The history is that it was reported as bug
The solution was to add config and handle it as a feature
It is nice to have in 202305, not must.
Get Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: StormLiangMS ***@***.***>
Sent: Sunday, August 6, 2023 5:22:44 PM
To: sonic-net/sonic-buildimage ***@***.***>
Cc: Liat Grozovik ***@***.***>; State change ***@***.***>
Subject: Re: [sonic-net/sonic-buildimage] [dns] Add support for static DNS configuration. (PR #14549)
@oleksandrivantsiv<https://github.com/oleksandrivantsiv> @ganglyu<https://github.com/ganglyu> For me, this looks like a feature other than bug fix, if so, not to 202305.
—
Reply to this email directly, view it on GitHub<#14549 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AKTABA2B7D4OQINWPFM5NQTXT6SDJANCNFSM6AAAAAAWVWR4IY>.
You are receiving this because you modified the open/close state.Message ID: ***@***.***>
|
|
@StormLiangMS can we finalize this? Should we backport the changes to 202305? Thanks, |
pdhruv-marvell
pushed a commit
to pdhruv-marvell/sonic-utilities
that referenced
this pull request
Aug 23, 2023
What I did sonic-net/sonic-buildimage#14549 This PR has introduced DNS configuration to CONFIG_DB, we need to migrate original CONFIG_DB to support DNS configuration during upgrading SONiC. How I did it If there's no DNS_NAMESERVER table in CONFIG_DB, read DNS_NAMESERVER table from minigraph and update CONFIG_DB. How to verify it Run unit test for db migrator.
rajkumar38
pushed a commit
to rajkumar38/sonic-utilities
that referenced
this pull request
Aug 28, 2023
What I did sonic-net/sonic-buildimage#14549 This PR has introduced DNS configuration to CONFIG_DB, we need to migrate original CONFIG_DB to support DNS configuration during upgrading SONiC. How I did it If there's no DNS_NAMESERVER table in CONFIG_DB, read DNS_NAMESERVER table from minigraph and update CONFIG_DB. How to verify it Run unit test for db migrator.
sonic-otn
pushed a commit
to sonic-otn/sonic-buildimage
that referenced
this pull request
Sep 20, 2023
- Why I did it Add support for static DNS configuration. According to sonic-net/SONiC#1262 HLD. - How I did it Add a new resolv-config.service that is responsible for transferring configuration from Config DB into /etc/resolv.conf file that is consumed by various subsystems in Linux to resolve domain names into IP addresses. - How to verify it Run the image compilation. Each component related to the static DNS feature is covered with the unit tests. Run sonic-mgmt tests. Static DNS feature will be covered with the system tests. Install the image and run manual tests.
lixiaoyuner
pushed a commit
to lixiaoyuner/sonic-buildimage
that referenced
this pull request
Feb 6, 2024
Highlight change, the DHCP config removed from master branch. files/image_config/resolv-config/resolv.conf Related work items: sonic-net#49, sonic-net#2598, sonic-net#11862, sonic-net#12530, sonic-net#14000, sonic-net#14549, sonic-net#14814, sonic-net#15077, sonic-net#15252, sonic-net#15253, sonic-net#15357, sonic-net#15384, sonic-net#15394, sonic-net#15399, sonic-net#15405, sonic-net#15566, sonic-net#15591, sonic-net#15592, sonic-net#15593, sonic-net#15602, sonic-net#15604, sonic-net#15611, sonic-net#15621, sonic-net#15625, sonic-net#15634, sonic-net#15635
lixiaoyuner
pushed a commit
to lixiaoyuner/sonic-buildimage
that referenced
this pull request
Feb 6, 2024
Merge code from master to internal Related work items: sonic-net#32, sonic-net#49, sonic-net#376, sonic-net#2598, sonic-net#11862, sonic-net#12530, sonic-net#14000, sonic-net#14547, sonic-net#14549, sonic-net#14814, sonic-net#15077, sonic-net#15239, sonic-net#15252, sonic-net#15253, sonic-net#15298, sonic-net#15357, sonic-net#15384, sonic-net#15394, sonic-net#15399, sonic-net#15405, sonic-net#15511, sonic-net#15566, sonic-net#15583, sonic-net#15591, sonic-net#15592, sonic-net#15593, sonic-net#15602, sonic-net#15604, sonic-net#15611, sonic-net#15621, sonic-net#15625, sonic-net#15634, sonic-net#15635, sonic-net#15645, sonic-net#15646, sonic-net#15647, sonic-net#15657, sonic-net#15658, sonic-net#15697, sonic-net#15699
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Add support for static DNS configuration. According to sonic-net/SONiC#1262 HLD.
How I did it
Add a new
resolv-config.servicethat is responsible for transferring configuration from Config DB into/etc/resolv.conffile that is consumed by various subsystems in Linux to resolve domain names into IP addresses.How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)