Deprecate PHPCR #408
Merged
Deprecate PHPCR #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
force-pushed
the
wipDeprecatePhpcr
branch
2 times, most recently
from
54ff63b
to
5e5ea52
Compare
|
If you think it's ok like this @jordisala1991 this require a dev-kit pr |
core23
reviewed
Apr 27, 2022
| /** | ||
| * This is a port of the DoctrineORMAdminBundle / ModelManager class. | ||
| * NEXT_MAJOR: Remove this class. |
There was a problem hiding this comment.
You should add an @deprecated comment so your IDE can highlight deprecation usage.
VincentLanglet
force-pushed
the
wipDeprecatePhpcr
branch
from
5e5ea52
to
8fae050
Compare
28 tasks
|
Please review @jordisala1991 |
jordisala1991
approved these changes
May 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
I am targeting this branch, because {reason}.
Closes #{put_issue_number_here}.
Changelog