Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The next release train #2009

Closed
28 tasks done
VincentLanglet opened this issue May 1, 2022 · 19 comments
Closed
28 tasks done

The next release train #2009

VincentLanglet opened this issue May 1, 2022 · 19 comments

Comments

@VincentLanglet
Copy link
Member

VincentLanglet commented May 1, 2022

Even if #1715 is not finished (some contributors are working on it) we may want to move on for other sonata packages.

The best would be to support all those new versions on SonataAdmin without the need for a new SonataAdmin major version.

Done:

  • SonataDoctrineExtension v2
  • Exporter v3
  • SonataTwigExtension v2
  • SonataIntl v3
  • SonataPage v4
@VincentLanglet
Copy link
Member Author

cc @dmaicher @jordisala1991, since you started working on it

@dmaicher
Copy link
Contributor

Regarding BlockBundle: Do we plan any more (breaking) changes for 5.0? Or are we close to releasing it?

@VincentLanglet maybe we can create another release on 4.x? See sonata-project/SonataBlockBundle@4.12.0...4.x

@VincentLanglet
Copy link
Member Author

Regarding BlockBundle: Do we plan any more (breaking) changes for 5.0? Or are we close to releasing it?

I think we're close to releasing it.
But I thought we could focus on extensions library before

@VincentLanglet
Copy link
Member Author

We might start soon to release the alphas cc @jordisala1991 @dmaicher

@VincentLanglet
Copy link
Member Author

VincentLanglet commented May 29, 2022

After the merge of sonata-project/exporter#593 we're ready.

Do you think we need an alpha/beta releases for those bundle ?

Edit: there are some issues to solve

@dmaicher
Copy link
Contributor

Yeah good for me 👍

@jordisala1991
Copy link
Member

Yes, we can do an alpha release for all of them and wait for the form-extensions

@VincentLanglet
Copy link
Member Author

@VincentLanglet
Copy link
Member Author

Should we release the stable version of exporter/twig-extension and doctrine-extensions @jordisala1991 @dmaicher ?

@jordisala1991
Copy link
Member

Exporter should be ready too. And we might try to prepare SonataIntlBundle too.

@VincentLanglet
Copy link
Member Author

Yes, I'm starting SonataIntlBundle with sonata-project/SonataIntlBundle#531

@VincentLanglet VincentLanglet mentioned this issue Jul 30, 2022
46 tasks
@VincentLanglet
Copy link
Member Author

Should we go for the stable release of SonataIntl 3 https://github.com/sonata-project/SonataIntlBundle/releases ?

@dmaicher
Copy link
Contributor

@VincentLanglet could we release BlockBundle v5? 🤔 This is waiting for a long time now

I would like to get rid of

sonata-project/cache          2.2.0              2.2.0              Cache library
Package sonata-project/cache is abandoned, you should avoid using it. No replacement was suggested.

I just tested on my biggest project and it works fine for me with composer req sonata-project/block-bundle "5.x-dev as 4.99".

We need to allow ^5.0 on SonataAdminBundle though

@VincentLanglet
Copy link
Member Author

I thought it was better to wait for formExtension before because of
https://github.com/sonata-project/SonataBlockBundle/blob/4.x/composer.json#L30
but maybe not.

I just tested on my biggest project and it works fine for me with composer req sonata-project/block-bundle "5.x-dev as 4.99".
Can you also try with formExtension 2.x-dev as 1.99 ?

I'd like to confirm that:

Then we can release BlockBundle 5.0 and add later in a minor the FormExtension 2.0 support.

@dmaicher
Copy link
Contributor

@VincentLanglet also additionally with composer req sonata-project/form-extensions "2.x-dev as 1.99" all my tests are passing and did some random manual testing: everything works fine

@VincentLanglet
Copy link
Member Author

Then we can release BlockBundle 5.0 and add later in a minor the FormExtension 2.0 support.

So we can consider this strategy then. I'll try to get a confirmation from jordi.
(And I won't have a lot of time before february.)

I assume can start with an alpha anyway.

@VincentLanglet
Copy link
Member Author

I lost track, not sure we did an alpha for block bundle v5. (cc @jordisala1991)

Now sonata-project/form-extensions#427 is merged, we could do an alpha for both block and form bundle.

@jordisala1991
Copy link
Member

Yes, we did not do an alpha for block bundle. It would be nice to do it. Also for form extensions (I only need to take a look at the twig thing for form extensions).

Do you have time to prepare the block bundle one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants