-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump static analysis #365
Bump static analysis #365
Conversation
Does someone (@sonata-project/contributors ) is familiar with One method is doing
the other is doing
Is there a bug or does it means that |
681cf05
to
1f7fcbf
Compare
Looking at the usage, the DoctrineCollector seems right So I updated the phpdoc of the DoctrineORMMapper to follow the same strategy. But I found no usage of |
7d37cae
to
b571a0a
Compare
Please review @sonata-project/contributors |
Could you please rebase your PR and fix merge conflicts? |
composer.json
Outdated
@@ -70,5 +74,13 @@ | |||
"psr-4": { | |||
"Sonata\\Doctrine\\Tests\\": "tests/" | |||
} | |||
}, | |||
"scripts": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be adapted
b571a0a
to
82822d9
Compare
@@ -2,13 +2,12 @@ includes: | |||
- phpstan-baseline.neon | |||
|
|||
parameters: | |||
level: 5 | |||
|
|||
level: max |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should stop using max, on phpstan 1.0 max is level 9, currently is level 8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a big deal since it require the bump from ^0.12 to ^1.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine, it is either changing it now or later, most likely we are not going to pass level 9 that easy
c807b98
to
d7bc09c
Compare
Subject
closes #236
Changelog