Remove dependency with doctrine/dbal #2193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Indeed, the method was removed in version 2.x. |
phansys
reviewed
Oct 31, 2021
phansys
approved these changes
Oct 31, 2021
VincentLanglet
approved these changes
Nov 1, 2021
Yep, That has to be done indeed. |
Just discovered I've already deprecated it in sonata-project/sonata-doctrine-extensions#365 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
The dependency is not really required, and that method should/will be deprecated on next major of doctrine extensions (because it is coupled with the orm, I couldn't find the getConnection on the document manager)
To me it is pedantic, because this only affects on the conflict section (for our users), for us it means not having to deal with one package here which is nice.