Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support php 8 #1303

Closed
wants to merge 3 commits into from
Closed

Support php 8 #1303

wants to merge 3 commits into from

Conversation

4c0n
Copy link
Contributor

@4c0n 4c0n commented Apr 20, 2021

Subject

Support php 8

I am targeting this branch, because I need the current version to support PHP 8.

Changelog

Support PHP 8.

@VincentLanglet
Copy link
Member

The sonata-project/cache-bundle need to support PHP8 first

@4c0n
Copy link
Contributor Author

4c0n commented Apr 20, 2021

@VincentLanglet Actually it seems that it already does: https://github.com/sonata-project/SonataCacheBundle/blob/d0b13b4dcc85272f2235e7fbd50578dd403222b0/composer.json#L22

However this bundle should support the newer version of that bundle:

"sonata-project/cache-bundle": "^2.4.1",

@VincentLanglet
Copy link
Member

Oh yes indeed, it required the sonata-project/cache-bundle 3.
Another option is to stop using the cache bundle, since it's deprecated.

#1096
sonata-project/SonataCacheBundle#279

@4c0n
Copy link
Contributor Author

4c0n commented Apr 20, 2021

@VincentLanglet Is that not a BC break? I'd rather remove it to be honest, but I guess it should be replaced with some integration of the standard Symfony cache support?

@VincentLanglet
Copy link
Member

@VincentLanglet Is that not a BC break? I'd rather remove it to be honest, but I guess it should be replaced with some integration of the standard Symfony cache support?

It depends how it's done, but I'm not sure. I know nothing about this bundle.

Another easy option could be to add support for php8 to the cache bundle v2.

@4c0n
Copy link
Contributor Author

4c0n commented Apr 20, 2021

@VincentLanglet turns out it wasn't too hard to use version 3: #1304
It's probably better to migrate away from the cache bundle to the default Symfony cache in a new major version.

@SonataCI
Copy link
Collaborator

Could you please rebase your PR and fix merge conflicts?

… feature/support-php-8

# Conflicts:
#	.github/workflows/test.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants