-
-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support php 8 #1303
Support php 8 #1303
Conversation
The sonata-project/cache-bundle need to support PHP8 first |
@VincentLanglet Actually it seems that it already does: https://github.com/sonata-project/SonataCacheBundle/blob/d0b13b4dcc85272f2235e7fbd50578dd403222b0/composer.json#L22 However this bundle should support the newer version of that bundle: SonataPageBundle/composer.json Line 31 in fed26c0
|
Oh yes indeed, it required the sonata-project/cache-bundle 3. |
@VincentLanglet Is that not a BC break? I'd rather remove it to be honest, but I guess it should be replaced with some integration of the standard Symfony cache support? |
It depends how it's done, but I'm not sure. I know nothing about this bundle. Another easy option could be to add support for php8 to the cache bundle v2. |
@VincentLanglet turns out it wasn't too hard to use version 3: #1304 |
Could you please rebase your PR and fix merge conflicts? |
… feature/support-php-8 # Conflicts: # .github/workflows/test.yaml
Subject
Support php 8
I am targeting this branch, because I need the current version to support PHP 8.
Changelog
Support PHP 8.