Deprecate this bundle

[core23]

Feature Request

There is no need for the bundle anymore. Symfony / PSR cache is more common. Even doctrine dropped their custom cache.

[greg0ire]

Even doctrine dropped there custom cache.

trying to, but not there yet I'm afraid :P

[VincentLanglet]

Let's start with the README #289

I don't have the right to edit the description and add [deprecated] like other packages

[core23]

@greg0ire @OskarStark can you do this?

[greg0ire]

Done

[greg0ire]

I'm wondering if it's not a bit premature… I mean we have lots of bundles relying on the cache bundle, shouldn't we move them to something else first?

[greg0ire]

It's not like the package is abandoned or triggering deprecations though 🤔
What do we mean exactly by deprecating? Asking because of sonata-project/dev-kit#617
Will we refuse any PRs ? Should we stop getting improvements from dev-kit?

[VincentLanglet]

IMO, we're just deprecating the package. Which means we're not recommending the usage of it, and recommend to use something else instead.

When we're deprecating something in a bundle,

• First we trigger a deprecation message
• Second we're fixing the deprecation in others bundle
• Third we're removing it

Adding [deprecated] is like the step one.

[greg0ire]

Should we stop getting improvements from dev-kit?

And this sounds like step 3

[VincentLanglet]

Should we stop getting improvements from dev-kit?

And this sounds like step 3

I don't really know what is doing the dev-kit.
@core23 Asked me a PR, so I copied the coreBundle one
sonata-project/dev-kit@85390bb#diff-70800a36c38d85e21390f3af255c8420

And the "step 2" is still not finished for the core-bundle.

So I can't say if we should revert these pr or not.
But if these PR shouldn't be made for Cache/Intl/EasyExtend in the devkit, it should not have been done for the CoreBundle too.

[greg0ire]

I guess this must be in order to avoid extra work when a dev-kit PR does not apply cleanly to one of these bundles. I will merge the cache PR and deploy, this is probably fine 🤞

[core23]

We should also add a new abandoned entry to the composer.json file

[greg0ire]

Wouldn't this trigger warnings for people using our other packages, like the block bundle?

[core23]

That's right but okay. We deprecated the bundle on GitHub, so we should deprecate the bundle everywhere

[jordisala1991]

This issue should be closed and instead one on PageBundle might be opened to track the efforts of remove this deprecated bundle from there.