Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: solidusio/solidus_support
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.3.2
Choose a base ref
...
head repository: solidusio/solidus_support
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.4.0
Choose a head ref
  • 17 commits
  • 20 files changed
  • 3 contributors

Commits on Oct 31, 2019

  1. Add support for Codecov

    aldesantis committed Oct 31, 2019
    Configuration menu
    Copy the full SHA
    0626cac View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2019

  1. Merge pull request #24 from aldesantis/code-coverage

    Add support for Codecov
    kennyadsl authored Nov 4, 2019
    Configuration menu
    Copy the full SHA
    b4f5739 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    18dd389 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2019

  1. Add SolidusSupport::EngineExtension::Decorators to load decorators

    This module is supposed to be used in extensions engines to
    remove boilerplate code.
    
    As is right now, it loads all the decorators correctly for
    both development and production environments, since we were
    having some issues with Zeitwerk not loading decorators in
    production.
    kennyadsl committed Dec 4, 2019
    Configuration menu
    Copy the full SHA
    c4c36be View commit details
    Browse the repository at this point in the history
  2. Merge pull request #27 from nebulab/nebulab/activate-decorators-produ…

    …ction
    
    Add SolidusSupport::EngineExtension::Decorators to load decorators
    kennyadsl authored Dec 4, 2019
    Configuration menu
    Copy the full SHA
    9df07a6 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2019

  1. Remove support for testing and extensions

    Some things of this gem will be moved to [solidus_extension_dev_tools](dev_tools)
    we should remove and/or deprecate those within solidus_support to avoid
    confusion and have a clear update path for extension maintainers.
    
    Extracted:
    + feature/spec helpers
    + coverage support
    + preferences stub (`stub_spree_preferences`)
    + extension decorator (`SolidusSupport::EngineExtensions::Decorators`)
    
    Ref. solidusio/solidus_dev_support#13
    
    [dev_tool]: https://github.com/solidusio-contrib/solidus_extension_dev_tools
    Flavio Auciello committed Dec 6, 2019
    Configuration menu
    Copy the full SHA
    1ee39a7 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2019

  1. Merge pull request #28 from MinasMazar/mm/extract-dev-tools

    Remove support for testing and extensions
    aldesantis authored Dec 13, 2019
    Configuration menu
    Copy the full SHA
    a2ae886 View commit details
    Browse the repository at this point in the history
  2. Bump version to 0.4.0

    aldesantis committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    ac8110e View commit details
    Browse the repository at this point in the history
  3. Add CircleCI configuration

    aldesantis committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    754633a View commit details
    Browse the repository at this point in the history
  4. Introduce solidus_extension_dev_tools for testing configuration

    We had removed the RSpec configuration helpers from here, but this
    caused the tests to fail because they relied on that same config.
    Using the configuration from solidus_extension_dev_tools fixes the
    issue.
    aldesantis committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    3051059 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    4652822 View commit details
    Browse the repository at this point in the history
  6. rubocop -a

    aldesantis committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    2e7d638 View commit details
    Browse the repository at this point in the history
  7. Merge pull request #31 from aldesantis/circleci

    Add CircleCI configuration
    kennyadsl authored Dec 13, 2019
    Configuration menu
    Copy the full SHA
    1b87714 View commit details
    Browse the repository at this point in the history
  8. Merge pull request #29 from aldesantis/dev-tools

    Introduce solidus_extension_dev_tools
    kennyadsl authored Dec 13, 2019
    Configuration menu
    Copy the full SHA
    13980a1 View commit details
    Browse the repository at this point in the history
  9. Fix Sprockets complaining about the lack of a manifest

    There is an issue with Sprockets 4 not accepting a custom path for
    the assets manifest, which doesn't play well with in-memory dummy
    apps such as the one we use in this gem.
    
    A fix was provided for sprockets-rails[1] but it was not accepted
    yet.
    
    [1]: rails/sprockets-rails#446
    aldesantis committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    93f6953 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2019

  1. Configuration menu
    Copy the full SHA
    e4bca8c View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2019

  1. Merge pull request #32 from aldesantis/sprockets

    Fix issues with test runs
    aldesantis authored Dec 16, 2019
    Configuration menu
    Copy the full SHA
    54cdba6 View commit details
    Browse the repository at this point in the history
Loading