Skip to content

Commit

Permalink
Introduce solidus_extension_dev_tools for testing configuration
Browse files Browse the repository at this point in the history
We had removed the RSpec configuration helpers from here, but this
caused the tests to fail because they relied on that same config.
Using the configuration from solidus_extension_dev_tools fixes the
issue.
  • Loading branch information
aldesantis committed Dec 13, 2019
1 parent ac8110e commit 3051059
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 4 deletions.
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,5 @@
/spec/reports/
/tmp/
/log/
/spec/

1 change: 1 addition & 0 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,6 @@ gem 'solidus_core', github: 'solidusio/solidus', branch: branch
# Specify your gem's dependencies in solidus_support.gemspec
gemspec

gem 'solidus_extension_dev_tools', github: 'solidusio-contrib/solidus_extension_dev_tools'
gem 'sprockets-rails'
gem 'sqlite3'
7 changes: 4 additions & 3 deletions solidus_support.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,11 @@ Gem::Specification.new do |spec|
spec.files = `git ls-files -z`.split("\x0")
spec.require_paths = ['lib']

spec.add_development_dependency 'bundler', '~> 1.14'
spec.add_development_dependency 'rake', '~> 10.0'
spec.add_development_dependency 'rspec-rails', '~> 3.7'
spec.add_development_dependency 'bundler'
spec.add_development_dependency 'rake'
spec.add_development_dependency 'rspec-rails'
spec.add_development_dependency 'rubocop'
spec.add_development_dependency 'rubocop-rspec'
spec.add_development_dependency 'solidus_core'
spec.add_development_dependency 'solidus_extension_dev_tools'
end
2 changes: 1 addition & 1 deletion spec/spec_helper.rb
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
require_relative 'support/dummy_app'
require 'solidus_support/extension/spec_helper'
require 'solidus_extension_dev_tools/rspec/spec_helper'

0 comments on commit 3051059

Please sign in to comment.