Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy extension-related stuff from solidus_support #13

Closed
elia opened this issue Nov 22, 2019 · 0 comments
Closed

Remove legacy extension-related stuff from solidus_support #13

elia opened this issue Nov 22, 2019 · 0 comments
Assignees

Comments

@elia
Copy link
Member

elia commented Nov 22, 2019

This gem has replaced many of the things solidus_support was doing, we should remove and/or deprecate those within solidus_support to avoid confusion and have a clear update path for extension maintainers.

@MinasMazar MinasMazar self-assigned this Nov 29, 2019
MinasMazar pushed a commit to MinasMazar/solidus_support that referenced this issue Dec 6, 2019
Some things of this gem will be moved to [solidus_extension_dev_tools](dev_tools)
we should remove and/or deprecate those within solidus_support to avoid
confusion and have a clear update path for extension maintainers.

Ref. solidusio/solidus_dev_support#13

[dev_tool]: https://github.com/solidusio-contrib/solidus_extension_dev_tools)
MinasMazar pushed a commit to MinasMazar/solidus_support that referenced this issue Dec 6, 2019
Some things of this gem will be moved to [solidus_extension_dev_tools](dev_tools)
we should remove and/or deprecate those within solidus_support to avoid
confusion and have a clear update path for extension maintainers.

Extracted:
+ feature/spec helpers
+ coverage support
+ preferences stub (`stub_spree_preferences`)
+ extension decorator (`SolidusSupport::EngineExtensions::Decorators`)

Ref. solidusio/solidus_dev_support#13

[dev_tool]: https://github.com/solidusio-contrib/solidus_extension_dev_tools)
MinasMazar pushed a commit to MinasMazar/solidus_support that referenced this issue Dec 6, 2019
Some things of this gem will be moved to [solidus_extension_dev_tools](dev_tools)
we should remove and/or deprecate those within solidus_support to avoid
confusion and have a clear update path for extension maintainers.

Extracted:
+ feature/spec helpers
+ coverage support
+ preferences stub (`stub_spree_preferences`)
+ extension decorator (`SolidusSupport::EngineExtensions::Decorators`)

Ref. solidusio/solidus_dev_support#13

[dev_tool]: https://github.com/solidusio-contrib/solidus_extension_dev_tools
MinasMazar pushed a commit that referenced this issue Dec 6, 2019
It was added in `solidus_support` with [this PR](solidus-support-pr) and
it has been extracted with [this PR](extract-pr).

Ref. #13

[solidus-support-pr]: solidusio/solidus_support#27
[extract-pr]: solidusio/solidus_support#28
MinasMazar pushed a commit that referenced this issue Dec 6, 2019
It was added in `solidus_support` with [this PR](solidus-support-pr) and
it has been extracted with [this PR](extract-pr).

Ref. #13

[solidus-support-pr]: solidusio/solidus_support#27
[extract-pr]: solidusio/solidus_support#28
MinasMazar pushed a commit that referenced this issue Dec 6, 2019
It was added in `solidus_support` with [this PR](solidus-support-pr) and
will be extracted with [this PR](extract-pr).

Ref. #13

[solidus-support-pr]: solidusio/solidus_support#27
[extract-pr]: solidusio/solidus_support#28
@MinasMazar MinasMazar added the blocked Blocked by external factors. label Dec 6, 2019
MinasMazar pushed a commit to MinasMazar/solidus_support that referenced this issue Dec 6, 2019
Some things of this gem will be moved to [solidus_extension_dev_tools](dev_tools)
we should remove and/or deprecate those within solidus_support to avoid
confusion and have a clear update path for extension maintainers.

Extracted:
+ feature/spec helpers
+ coverage support
+ preferences stub (`stub_spree_preferences`)
+ extension decorator (`SolidusSupport::EngineExtensions::Decorators`)

Ref. solidusio/solidus_dev_support#13

[dev_tool]: https://github.com/solidusio-contrib/solidus_extension_dev_tools
@MinasMazar MinasMazar removed the blocked Blocked by external factors. label Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants