Vcr improvements

spec/controllers/solidus_paypal_braintree/checkouts_controller_spec.rb

@@ -4,8 +4,7 @@
 RSpec.describe SolidusPaypalBraintree::CheckoutsController, type: :controller do
   include_context 'order ready for payment'
 
-  cassette_options = { cassette_name: "checkouts_controller/update" }
-  describe 'PATCH update', vcr: cassette_options do
+  describe 'PATCH update', vcr: { cassette_name: 'checkout/update' } do
     subject(:patch_update) { patch :update, params }
 
     let(:params) do

spec/controllers/solidus_paypal_braintree/transactions_controller_spec.rb

@@ -10,8 +10,7 @@
     allow(controller).to receive(:current_order) { order }
   end
 
-  cassette_options = { cassette_name: "transactions_controller/create" }
-  describe "POST create", vcr: cassette_options do
+  describe "POST create" do
     subject(:post_create) { post :create, params }
 
     let(:params) do
@@ -35,7 +34,19 @@
       }
     end
 
-    context "when the transaction is valid" do
+    context "import has invalid address" do
+      before { params[:transaction][:address_attributes][:city] = nil }
+
+      it "raises a validation error" do
+        expect { post_create }.to raise_error(
+          SolidusPaypalBraintree::TransactionImport::InvalidImportError,
+          "Validation failed: " \
+          "Transactionaddress city can't be blank"
+        )
+      end
+    end
+
+    context "when the transaction is valid", vcr: { cassette_name: 'transaction/import/valid' } do
       it "imports the payment" do
         expect { post_create }.to change { order.payments.count }.by(1)
         expect(order.payments.first.amount).to eq 55
@@ -51,18 +62,6 @@
         end
       end
 
-      context "and an invalid address is provided" do
-        before { params[:transaction][:address_attributes][:city] = nil }
-
-        it "raises a validation error" do
-          expect { post_create }.to raise_error(
-            SolidusPaypalBraintree::TransactionImport::InvalidImportError,
-            "Validation failed: " \
-            "Transactionaddress city can't be blank"
-          )
-        end
-      end
-
       context "and the transaction does not have an address" do
         before { params[:transaction].delete(:address_attributes) }