This repository has been archived by the owner on Apr 14, 2023. It is now read-only.
Vcr improvements #30
Merged
Vcr improvements #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
September 17, 2016 13:42
- Won't use cassettes unless explicitely requested by the spec - Will error out if any cassettes aren't using all the requests This will mean our cassettess have to be tight and exact, or the specs will fail.
These were the easy ones.
If we use the same nonce it'll make all the same calls.
cbrunsdon
force-pushed
the
vcr_improvements
branch
from
b000cda to
5388ced
Compare
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I rejiggered the vcr config to set allow_unused_http_interactions to false, as previously the cassettes were pretty messy and tough to know what could or should be happening in any one of them.
To do this reasonably I had to yank them all and add them back in slowly, I could rebase if requested. You'll notice we lose a few cassettes and a few hundred lines of interactions, so I'm calling this an improvement.