This repository was archived by the owner on Apr 14, 2023. It is now read-only.
Only add state if available in Paypal Checkout Button View #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
approved these changes
Sep 26, 2019
mamhoff
force-pushed
the
conditional-state-address
branch
from
0d97c8c to
49d44fb
Compare
mamhoff
force-pushed
the
conditional-state-address
branch
from
49d44fb to
a1f5f91
Compare
|
Rebased with latest master |
This Object exists only so that a Spree Address can be rendered out in a view in the right way, and so that that rendering is testable.
mamhoff
force-pushed
the
conditional-state-address
branch
from
a1f5f91 to
b109ac6
Compare
After cloning from master, bundler decided to install gems into the .bundle directory. This is fine, but it shouldn't mess up my commits. Similarly, I like to use .env files to manage credentials for projects, and I don't want those to end up on an open source repo.
Without requiring the root `::Spree::Config` constant, we run into load errors.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors some logic out of the paypal checkout button view and only adds a state name to the address hash there if the state is configured and necessary.
Fixes #182
Supersedes #196 and #231