Skip to content
This repository has been archived by the owner on Apr 14, 2023. It is now read-only.

Respect state configuration #231

Closed

Conversation

digitalWestie
Copy link

Helps solve #93

@spaghetticode
Copy link
Member

@digitalWestie can you squash the 4 commits into a single one? So we keep git history clean, thank you!

@digitalWestie
Copy link
Author

@spaghetticode done :)

Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this works, thanks!

Copy link
Member

@spaghetticode spaghetticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@digitalWestie thank you 👍

@tvdeyen
Copy link
Member

tvdeyen commented Sep 26, 2019

Thanks for the contribution. Might be superseded by #237 that also has tests.

@digitalWestie
Copy link
Author

Looks like #237 is a clean way of achieving this.

@tvdeyen
Copy link
Member

tvdeyen commented Sep 27, 2019

@digitalWestie I agree, do you mind closing this? Thanks for contributing anyway 👏

@tvdeyen tvdeyen closed this Sep 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants