Skip to content
This repository has been archived by the owner on Apr 14, 2023. It is now read-only.

Use transaction status to decide if payment can_void? #109

Merged
merged 2 commits into from
Oct 11, 2017
Merged

Use transaction status to decide if payment can_void? #109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ea77fa
Use transaction status to decide if payment can_void?
tvdeyen Jul 17, 2017
f46f97e
Re-record admin payment cassettes
tvdeyen Jul 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion app/models/solidus_paypal_braintree/source.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,11 @@ def can_capture?(payment)
end

def can_void?(payment)
!payment.failed? && !payment.void?
return false unless payment.response_code
transaction = braintree_client.transaction.find(payment.response_code)
Gateway::VOIDABLE_STATUSES.include?(transaction.status)
rescue Braintree::NotFoundError
false
end

def can_credit?(payment)
Expand Down
Loading