This repository has been archived by the owner on Apr 14, 2023. It is now read-only.
Use transaction status to decide if payment can_void? #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the transaction status changes asynchronously to the payment state, we need to ask the transaction if its status has a voidable state, to decide if a payment can be voided or not.
We need to record the check for current transaction status in the vcr cassettes.
tvdeyen
force-pushed
the
only-void-if-voidable
branch
from
06ae605 to
f46f97e
Compare
adammathys
approved these changes
Oct 11, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the transaction status changes asynchronously to the payment state,
we need to ask the transaction if its status has a voidable state,
to decide if a payment can be voided or not.